[Fixes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section #4914

sandramsc · 2023-09-15T14:10:37Z

Description

This PR related to #4871

Screenshot

Signed commits

Yes, I signed my commits.

l5io · 2023-09-15T14:25:09Z

🚀 Preview for commit d9f43d3 at: https://6504690205ed743019686c5e--layer5.netlify.app

l5io · 2023-09-15T14:41:48Z

🚀 Preview for commit b3bd0b9 at: https://65046cf07b71872c42aa80ae--layer5.netlify.app

sandramsc · 2023-09-15T16:06:33Z

in the first commit, I signed before pushing to screenshots/sandramsc/4871 (configured to do so automatically by Git before pushing)
then in the second commit as suggested by DCO
However, the error still persists.... 🤔, any suggestions on how to resolve, assuming changes are good and this is a merge blocker?

ritiksaxena124 · 2023-09-15T18:36:58Z

Thank you @sandramsc 👌 you did great.
Some changes are needed like Icons are missing in the screenshot will you update the screenshot that has icons visible?

sandramsc · 2023-09-15T19:18:43Z

Thank you @sandramsc 👌 you did great. Some changes are needed like Icons are missing in the screenshot will you update the screenshot that has icons visible?

Hi @ritiksaxena124 thanks for the feedback, do you mind clarifying which of the two screenshots is missing icons and in which section of the screenshot?

Original Screenshots

Design

Visualize

Suggested Screenshots

Design

Visualize

ritiksaxena124 · 2023-09-15T19:55:23Z

Suggested screenshots have missing icons @sandramsc.
In Designer icons on the sidebar are missing
In Visualizer Icons on the canvas are missing, Meshery logo and MeshMap logo are missing in the sidebar

Mohith234

Looks good to me @sandramsc, Great Job 🚀

Do make the changes requested by @ritiksaxena124
Also, for the DCO failing part, you can do this

git checkout <branch-name>
git commit --amend -s
git push -f origin <branch-name>

What it does is it adds the signoff to the commit you made.

Ghat0tkach · 2023-09-18T09:57:55Z

hey @sandramsc

Let's discuss it on the websites call.
I have already added your agenda as part of today's meeting minutes

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

sandramsc · 2023-09-18T11:01:42Z

hey @sandramsc

Let's discuss it on the websites call. I have already added your agenda as part of today's meeting minutes

https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

Sounds good 👍🏾

sandramsc · 2023-09-19T13:33:00Z

Hi, I made the updates based on feedback, however when rendering the website locally or previewing it here the new images do not render only the old ones, which have been removed. The cache was cleared before the images were updated in local repo.

Any suggestion as to why this is the case?

Mohith234 · 2023-09-21T10:00:28Z

src/collections/integrations/akri/index.mdx

+    ../_images/meshmap-designer_light.png,
+    ../_images/meshmap-visualizer_light.png,
+    ../_images/meshmap-designer_dark.png,
+    ../_images/meshmap-visualizer_dark.png]


Suggested change

../_images/meshmap-visualizer_dark.png]

../_images/meshmap-visualizer_dark.png,]

The Build and Preview Site and lighthouseci checks are failed because of this i believe

Thanks for the feedback @Mohith234 I spent the day yesterday trying to resolve this issue.

What I tried:

Based on your feedback I added the additional comma(,) after the last image link, this did not resolve the issue i.e the new screenshots did not render.

Thereafter I tried deleting the nodmodules, cache and package-lock.json file and folder, then ran npm i to re-install the dependencies this did not work as make site resulted in this error make: *** [Makefile:26: site] Error 137

Then I deleted the entire local project, re-installed it following the installation guide i.e make setup again, before creating the branch related to this PR I ran make site to see if the app would open, and it did as expected. I then created the branch related to this PR and pulled the remote changes to the local project, ran make site....the issue persisted i.e the new screenshots were not rendering.

I then proceeded to delete the screenshots and the related links in the index.mdx, and added them again, however, this did not resolve the issue either.

The error seems to be connected to GraphQL schema, please see the screenshot below, I scanned the documentation from the suggested site, but didn't see a hint to a solution there connected to this specific issue.

Mohith234 · 2023-09-23T09:34:01Z

Couldn't find out what was the thing that is causing this error, But I found that there is another PR for the same issue.

Ref #4928 @sandramsc

sandramsc · 2023-09-23T11:38:40Z

Couldn't find out what was the thing that is causing this error, But I found that there is another PR for the same issue.

Ref #4928 @sandramsc

You are correct in that it's related to screenshots, however after taking a look at the issue number for the PR mentioned above they are different.

I will continue to find a solution for the next couple days, however still eager to get more feedback that might aid in a hint towards resolving the GraphQL issue or creating a better solution.

Thanks again.

Mohith234 · 2023-09-24T10:16:11Z

Couldn't find out what was the thing that is causing this error, But I found that there is another PR for the same issue.
Ref #4928 @sandramsc

You are correct in that it's related to screenshots, however after taking a look at the issue number for the PR mentioned above they are different.

I will continue to find a solution for the next couple days, however still eager to get more feedback that might aid in a hint towards resolving the GraphQL issue or creating a better solution.

Thanks again.

I was referring that you've been working on Akri's index.mdx file as far as I'm able to see in the Files Changed

saurabh100ni · 2023-09-25T07:21:05Z

let's discuss this item on today's website meeting,
please add this agenda in the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.69qskjv558bk

…ator Signed-off-by: Sandra Ashipala <[email protected]>

sandramsc · 2023-09-25T20:04:21Z

Couldn't find out what was the thing that is causing this error, But I found that there is another PR for the same issue.
Ref #4928 @sandramsc

You are correct in that it's related to screenshots, however after taking a look at the issue number for the PR mentioned above they are different.
I will continue to find a solution for the next couple days, however still eager to get more feedback that might aid in a hint towards resolving the GraphQL issue or creating a better solution.
Thanks again.

I was referring that you've been working on Akri's index.mdx file as far as I'm able to see in the Files Changed

Thanks for pointing this out, additionally the error was caused by deleting the old screenshots as these were actually being used in other parts of the repo, the fix or rather the solution was simply to add the new screenshots in addition to the old ones. Let me know if there are pending changes after the most recent push.

Local render

l5io · 2023-09-25T20:14:16Z

🚀 Preview for commit 44180b0 at: https://6511e97cb5ff0c0ba6cac8fb--layer5.netlify.app

Mohith234

Looks good to me @sandramsc, Nicely done 👏

l5io · 2023-10-22T23:12:53Z

🚀 Preview for commit e91ccbf at: https://6535ac0d0c661e3c40581529--layer5.netlify.app

l5io · 2023-10-23T19:11:45Z

🚀 Preview for commit b376632 at: https://6536c517df36db00a4bb244a--layer5.netlify.app

l5io · 2023-10-24T23:23:28Z

🚀 Preview for commit 1d899f9 at: https://653851a41becbf1374602014--layer5.netlify.app

github-actions bot added the project/meshery label Sep 15, 2023

github-actions bot added area/community area/handbook labels Sep 15, 2023

leecalcote requested review from ritiksaxena124, Chadha93, Mohith234 and Modern-artist September 15, 2023 16:30

Mohith234 reviewed Sep 15, 2023

View reviewed changes

abhijeetgauravm mentioned this pull request Sep 16, 2023

adding-updated-designs-to-how-it-works-section #4888

Closed

1 task

github-actions bot removed area/community area/handbook labels Sep 19, 2023

sandramsc requested a review from Mohith234 September 20, 2023 12:20

Mohith234 reviewed Sep 21, 2023

View reviewed changes

sandramsc changed the title ~~[Closes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section~~ [Fixes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section Sep 23, 2023

updated screenshot links in index.mdx for the folder cd-pipeline-oper…

44180b0

…ator Signed-off-by: Sandra Ashipala <[email protected]>

sandramsc requested a review from Mohith234 September 25, 2023 20:11

Mohith234 approved these changes Sep 28, 2023

View reviewed changes

sandramsc mentioned this pull request Sep 29, 2023

update screen shots #4985

Merged

1 task

leecalcote removed the request for review from Chadha93 September 30, 2023 15:14

This was referenced Oct 12, 2023

Added screenshots for epam integration #5018

Merged

[Screenshots] BFE under 'How it Works See It in Action' section #4857

Open

[Screenshots] CRI-O under 'How it Works See It in Action' section #4990

Merged

sandramsc mentioned this pull request Oct 20, 2023

Updated Screen Shots of Cdk8s for Kubernetes #5067

Closed

1 task

Merge branch 'layer5io:master' into screenshots/sandramsc/4871

e91ccbf

Merge branch 'layer5io:master' into screenshots/sandramsc/4871

b376632

Merge branch 'layer5io:master' into screenshots/sandramsc/4871

1d899f9

sudhanshutech merged commit bc19cb8 into layer5io:master Nov 8, 2023
4 checks passed

sandramsc deleted the screenshots/sandramsc/4871 branch November 28, 2023 20:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fixes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section #4914

[Fixes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section #4914

sandramsc commented Sep 15, 2023 •

edited by sudhanshutech

Loading

l5io commented Sep 15, 2023

l5io commented Sep 15, 2023

sandramsc commented Sep 15, 2023 •

edited

Loading

ritiksaxena124 commented Sep 15, 2023

sandramsc commented Sep 15, 2023 •

edited

Loading

ritiksaxena124 commented Sep 15, 2023 •

edited

Loading

Mohith234 left a comment

Ghat0tkach commented Sep 18, 2023

sandramsc commented Sep 18, 2023

sandramsc commented Sep 19, 2023 •

edited

Loading

Mohith234 Sep 21, 2023

Mohith234 Sep 21, 2023

sandramsc Sep 22, 2023 •

edited

Loading

Mohith234 commented Sep 23, 2023

sandramsc commented Sep 23, 2023 •

edited

Loading

Mohith234 commented Sep 24, 2023

saurabh100ni commented Sep 25, 2023

sandramsc commented Sep 25, 2023 •

edited

Loading

l5io commented Sep 25, 2023

Mohith234 left a comment

l5io commented Oct 22, 2023

l5io commented Oct 23, 2023

l5io commented Oct 24, 2023

	../_images/meshmap-visualizer_dark.png]
	../_images/meshmap-visualizer_dark.png,]

[Fixes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section #4914

[Fixes - Screenshots] CD Pipeline Operator under 'How it Works See It in Action' section #4914

Conversation

sandramsc commented Sep 15, 2023 • edited by sudhanshutech Loading

l5io commented Sep 15, 2023

l5io commented Sep 15, 2023

sandramsc commented Sep 15, 2023 • edited Loading

ritiksaxena124 commented Sep 15, 2023

sandramsc commented Sep 15, 2023 • edited Loading

Original Screenshots

Design

Visualize

Suggested Screenshots

Design

Visualize

ritiksaxena124 commented Sep 15, 2023 • edited Loading

Mohith234 left a comment

Choose a reason for hiding this comment

Ghat0tkach commented Sep 18, 2023

sandramsc commented Sep 18, 2023

sandramsc commented Sep 19, 2023 • edited Loading

Mohith234 Sep 21, 2023

Choose a reason for hiding this comment

Mohith234 Sep 21, 2023

Choose a reason for hiding this comment

sandramsc Sep 22, 2023 • edited Loading

Choose a reason for hiding this comment

Mohith234 commented Sep 23, 2023

sandramsc commented Sep 23, 2023 • edited Loading

Mohith234 commented Sep 24, 2023

saurabh100ni commented Sep 25, 2023

sandramsc commented Sep 25, 2023 • edited Loading

Local render

l5io commented Sep 25, 2023

Mohith234 left a comment

Choose a reason for hiding this comment

l5io commented Oct 22, 2023

l5io commented Oct 23, 2023

l5io commented Oct 24, 2023

sandramsc commented Sep 15, 2023 •

edited by sudhanshutech

Loading

sandramsc commented Sep 15, 2023 •

edited

Loading

sandramsc commented Sep 15, 2023 •

edited

Loading

ritiksaxena124 commented Sep 15, 2023 •

edited

Loading

sandramsc commented Sep 19, 2023 •

edited

Loading

sandramsc Sep 22, 2023 •

edited

Loading

sandramsc commented Sep 23, 2023 •

edited

Loading

sandramsc commented Sep 25, 2023 •

edited

Loading