Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Screen Shots of Cdk8s for Kubernetes #5067

Closed
wants to merge 0 commits into from
Closed

Updated Screen Shots of Cdk8s for Kubernetes #5067

wants to merge 0 commits into from

Conversation

narasimha-1511
Copy link
Member

@narasimha-1511 narasimha-1511 commented Oct 20, 2023

Description

This PR fixes #4863

Notes for Reviewers
Changed the previous ScreenShots

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Oct 20, 2023

🚀 Preview for commit 7fab0d7 at: https://653213a9185e4f5e3f4a6f8b--layer5.netlify.app

Copy link
Member

@sandramsc sandramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screenshots look good to me. However based on previous feedback here @Mohith234 , would you still suggest that the subcategory icons in the sidebar be made visible? It might help to include this requirement in the issue template to reduce repetition.

@Mohith234
Copy link
Member

I don't think the subcategories are necessary @sandramsc, The feedback provided here was about the normal sidebar icons which weren't present on your initial commit of the PR.

Also, I suggest the screenshots in this current PR be only of the browser and not the whole screen (including the desktop icons on the side ).

// @narasimha-1511

@sandramsc
Copy link
Member

I don't think the subcategories are necessary @sandramsc, The feedback provided here was about the normal sidebar icons which weren't present on your initial commit of the PR.

Also, I suggest the screenshots in this current PR be only of the browser and not the whole screen (including the desktop icons on the side ).

// @narasimha-1511

I see which screenshot you were reffering to now. This clears up that misunderstanding on my end.

@sandramsc
Copy link
Member

@narasimha-1511 in addition to what @Mohith234 mentioned, please take note of the following:

  • Use Incognito mode on Chrome browser, to ensure your bookmark bar or any other items are not shown in the screenshot/video.

These points have been stated in the issue description.

@narasimha-1511
Copy link
Member Author

@sandramsc
Hey , I will again Upload these Images with Incongito ..
Thanks For the feedback

@github-actions
Copy link

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Mohith234
Copy link
Member

@narasimha-1511 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@narasimha-1511
Copy link
Member Author

I have added today @Mohith234

@sudhanshutech
Copy link
Member

any update @narasimha-1511 ?

@narasimha-1511
Copy link
Member Author

@sudhanshutech I will Update the screen shots removing the task bar .

@leecalcote
Copy link
Member

Thanks, @narasimha-1511. 👍

Heads-up: there is a merge conflict to resolve.

@narasimha-1511
Copy link
Member Author

narasimha-1511 commented Nov 30, 2023

@leecalcote I have made mistake while pushing the commits so i created a new pr

#5169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Screenshots] Cdk For Kubernetes (Cdk8S) under 'How it Works See It in Action' section
6 participants