-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Screen Shots of Cdk8s for Kubernetes #5067
Updated Screen Shots of Cdk8s for Kubernetes #5067
Conversation
🚀 Preview for commit 7fab0d7 at: https://653213a9185e4f5e3f4a6f8b--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshots look good to me. However based on previous feedback here @Mohith234 , would you still suggest that the subcategory icons in the sidebar be made visible? It might help to include this requirement in the issue template to reduce repetition.
I don't think the subcategories are necessary @sandramsc, The feedback provided here was about the normal sidebar icons which weren't present on your initial commit of the PR. Also, I suggest the screenshots in this current PR be only of the browser and not the whole screen (including the desktop icons on the side ). |
I see which screenshot you were reffering to now. This clears up that misunderstanding on my end. |
@narasimha-1511 in addition to what @Mohith234 mentioned, please take note of the following:
These points have been stated in the issue description. |
@sandramsc |
Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.
|
@narasimha-1511 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes. |
I have added today @Mohith234 |
any update @narasimha-1511 ? |
@sudhanshutech I will Update the screen shots removing the task bar . |
Thanks, @narasimha-1511. 👍 Heads-up: there is a merge conflict to resolve. |
@leecalcote I have made mistake while pushing the commits so i created a new pr |
Description
This PR fixes #4863
Notes for Reviewers
Changed the previous ScreenShots
Signed commits