Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added screenshots for epam integration #5018

Merged

Conversation

ankushbhardwaj408
Copy link
Member

Description

This PR fixes #4829

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Oct 9, 2023

🚀 Preview for commit fac9a58 at: https://65244380f2a8d71ccddd98c8--layer5.netlify.app

Copy link
Member

@sandramsc sandramsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ankushbhardwaj408 , thank you for your contribution, please create new screenshot for visualizer as icons are missing from the canvas. View the comment on this PR for more context.

@ankushbhardwaj408
Copy link
Member Author

Sure @sandramsc i'll work on it.

@l5io
Copy link
Contributor

l5io commented Oct 12, 2023

🚀 Preview for commit 5759ab8 at: https://6527fbd6dbaa8e1b51cd2e72--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 15, 2023

🚀 Preview for commit 7da025b at: https://652c196f0ec6f612db66d736--layer5.netlify.app

@saurabh100ni
Copy link
Contributor

Thanks for raising PR, Let's discuss this in the Website call today at 5:30 PM IST.
Please add this as your agenda in Docs

@l5io
Copy link
Contributor

l5io commented Oct 18, 2023

🚀 Preview for commit 68269f6 at: https://652f887ea49f01639882b5ac--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Oct 20, 2023

🚀 Preview for commit 4a1489a at: https://6532050afd8e6c55bca590d4--layer5.netlify.app

@ankushbhardwaj408
Copy link
Member Author

Hi @ankushbhardwaj408 , thank you for your contribution, please create new screenshot for visualizer as icons are missing from the canvas. View the comment on this PR for more context.

@sandramsc please review this pr now.

@l5io
Copy link
Contributor

l5io commented Oct 28, 2023

🚀 Preview for commit 4f74bc9 at: https://653d23bd8abfc044241b810f--layer5.netlify.app

@Mohith234
Copy link
Member

@ankushbhardwaj408 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Nov 4, 2023

🚀 Preview for commit 178862a at: https://65461539b9207a663c40abe1--layer5.netlify.app

@sudhanshutech
Copy link
Member

@ankushbhardwaj408 merge conflict

@ankushbhardwaj408
Copy link
Member Author

@sudhanshutech merge conflicts resolved.

@l5io
Copy link
Contributor

l5io commented Nov 13, 2023

🚀 Preview for commit 8f0a584 at: https://655251c3f309090077bfba1a--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Nov 14, 2023

🚀 Preview for commit 8c75a4d at: https://6553812b9d19d20c028ef8b9--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 3, 2023

🚀 Preview for commit ee1f9a4 at: https://656cbb35cb669e290e5bc1a2--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit 3f36062 at: https://656d4e28918b00027ff11e06--layer5.netlify.app

@ankushbhardwaj408
Copy link
Member Author

ankushbhardwaj408 commented Dec 4, 2023

@leecalcote @vishalvivekm i am not able to commit new changes
Screenshot 2023-12-04 083420
Screenshot 2023-12-04 083449

I think this is due to embed tests in static folder. I have deleted the entire repo and restarted the local server but still this error is appearing while commiting

@vishalvivekm vishalvivekm mentioned this pull request Dec 4, 2023
1 task
@vishalvivekm
Copy link
Member

@leecalcote @vishalvivekm i am not able to commit new changes Screenshot 2023-12-04 083420 Screenshot 2023-12-04 083449

Thanks for reporting this @ankushbhardwaj408.

@ankushbhardwaj408
Copy link
Member Author

@vishalvivekm ??

@vishalvivekm vishalvivekm reopened this Dec 4, 2023
@vishalvivekm
Copy link
Member

@vishalvivekm ??

Apologies, I mistakenly closed it.
Can you see if the errors are gone, if you update your local repo to the upstream now? @ankushbhardwaj408

@ankushbhardwaj408
Copy link
Member Author

@vishalvivekm no problem, i will try now and let you know.

@ankushbhardwaj408
Copy link
Member Author

Thank you @vishalvivekm it worked 🎉

@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit a7b5172 at: https://656da58a5dabd336817f3927--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankushbhardwaj408 the folder in _images/ has to be named epam-delivery-platform-edp-admin-console

Here the title is : Epam Delivery Platform (EDP) Admin Console
its sluggified versoin: epam-delivery-platform-edp-admin-console

: #5129 (comment)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change it🫡

@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit 42ef16c at: https://656daaaddb89ad3b2341618f--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit e8c9a12 at: https://656de5f3eb29fa00871c3719--layer5.netlify.app

Signed-off-by: Ankush Bhardwaj <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit 214838a at: https://656ded6f65c6b305ac017999--layer5.netlify.app

Signed-off-by: vishalvivekm <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit a050664 at: https://656e1427fa1051009a473201--layer5.netlify.app

Signed-off-by: vishalvivekm <[email protected]>
@l5io
Copy link
Contributor

l5io commented Dec 4, 2023

🚀 Preview for commit 9083133 at: https://656e1bba569df9008c20047a--layer5.netlify.app

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thank you @ankushbhardwaj408

@vishalvivekm vishalvivekm merged commit 6a19ef5 into layer5io:master Dec 4, 2023
4 checks passed
@ankushbhardwaj408 ankushbhardwaj408 deleted the ankushbhardwaj408-#4829 branch December 4, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Screenshots] Epam Delivery Platform (EDP) Admin Console under "How it Works See It in Action” section
8 participants