Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Screenshots] BFE under 'How it Works See It in Action' section #4857

Open
saurabh100ni opened this issue Sep 7, 2023 · 11 comments
Open

[Screenshots] BFE under 'How it Works See It in Action' section #4857

saurabh100ni opened this issue Sep 7, 2023 · 11 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed issue/remind

Comments

@saurabh100ni
Copy link
Contributor

Current Behavior

Currently, every integration has only two old screenshots of the designer and visualizer in the 'How it Works See It in Action' section.

Desired Behavior

  • Add new images and videos from the latest version of the software (MeshMap)
  • Add screenshots for BFE integration.

Acceptance Tests

  • Ensure your screenshot represents the use of a few specific integrations.
  • The screenshot from the Designer mode should contain a valid design, refer to meshery catalog to use and view published designs.
  • Add both Dark Mode and Light Mode screenshots.
  • The screenshot should not be a snippet, take the full screenshot of your browser.
  • Use Incognito mode on Chrome browser, to ensure your bookmark bar or any other items are not shown in the screenshot/video.

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

@Ghat0tkach Ghat0tkach added good first issue Good for newcomers help wanted Extra attention is needed labels Sep 7, 2023
@saurabh100ni saurabh100ni added the hacktoberfest Happy contributing! label Sep 22, 2023
@HarshDeep61034
Copy link

i would like to work on this, assign this to me.

@saurabh100ni
Copy link
Contributor Author

Go on @HarshDeep61034 😎🚀

@HarshDeep61034
Copy link

@saurabh100ni will these work ?
Screenshot from 2023-10-11 14-26-44
Screenshot from 2023-10-11 14-27-03

@saurabh100ni
Copy link
Contributor Author

saurabh100ni commented Oct 11, 2023

@HarshDeep61034 we have @sudhanshutech as reviewer, he will update us soon.

@sandramsc
Copy link
Member

sandramsc commented Oct 12, 2023

@saurabh100ni will these work ? Screenshot from 2023-10-11 14-26-44 Screenshot from 2023-10-11 14-27-03

For the visualizer screenshot, icons are missing from the canvas. See the comment on this PR for more context.

Update: Following up with an update from Slack and Zoom call related to the expected visuals of the screenshots:

  • Both the designer and visualizer screenshots LGMT (the visualizer renders visually as expected, based on selected filters i.e icons aren't "missing" in this case)
  • The issue description states that incognito mode should be used to avoid bookmarks being captured in the screenshot (in this case please consider re-reading the issue description to understand the desired solution)
  • Also suggest capturing only the window in question (i.e close unrelated tabs)

@saurabh100ni
Copy link
Contributor Author

@sudhanshutech @Yashsharma1911 //

Copy link

github-actions bot commented Nov 2, 2023

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@sandramsc sandramsc removed the hacktoberfest Happy contributing! label Nov 3, 2023
@sandramsc
Copy link
Member

@HarshDeep61034 any update on progress?

@sandramsc
Copy link
Member

This issue has been open for some time with no recent activity, unassigning to open it up for new contributors to give it a go.

@kohantikanath
Copy link

Hi @sandramsc @saurabh100ni,

I would love to work on this issue. Can you please assign it to me?

@narasimha-1511
Copy link
Member

Go on @kohantikanath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed issue/remind
Development

No branches or pull requests

6 participants