Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding-updated-designs-to-how-it-works-section #4888

Closed
wants to merge 2 commits into from
Closed

adding-updated-designs-to-how-it-works-section #4888

wants to merge 2 commits into from

Conversation

PRANJALRANA11
Copy link
Contributor

Description
i have updated the how it works section with updated images both in light and dark mode
This PR fixes #4826

Signed commits

  • Yes, I signed my commits.

@PRANJALRANA11
fixing layer5io#4826
01a7fb0 
Signed-off-by: PRANJALRANA11 <[email protected]>
@PRANJALRANA11
adding the dark mode images
a709b32 
Signed-off-by: PRANJALRANA11 <[email protected]>
@l5io
Copy link
Contributor

l5io commented Sep 7, 2023

🚀 Preview for commit a709b32 at: https://64f9bd844150e70a9d0b5ed2--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Sep 7, 2023

🚀 Preview for commit a709b32 at: https://64f9bfb9a39a4411137bc3a3--layer5.netlify.app

@Ghat0tkach
Copy link
Member

hey @PRANJALRANA11
Let's discuss it on the websites call.
Please add this as an agenda item in the meeting minutes, if you would :)
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit#heading=h.lohhtewfwima

@PRANJALRANA11
Copy link
Contributor Author

hey @Ghat0tkach i am not able to understand what are you asking and docs stuff could you please explain

@Ghat0tkach
Copy link
Member

@PRANJALRANA11 , we have our weekly website meeting minutes where we review your PR and takes your feedback.
Join slack channel to get timings of the meeting.

@PRANJALRANA11
Copy link
Contributor Author

ok

abhijeetgauravm
abhijeetgauravm suggested changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@abhijeetgauravm abhijeetgauravm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @PRANJALRANA11 in preview still not able to see the new screenshots of the designer and visualizer from the latest version of the software (MeshMap)
image

image

See this for reference #4914

@PRANJALRANA11
Copy link
Contributor Author

@abhijeetgauravm
image

@PRANJALRANA11
Copy link
Contributor Author

but i had added it already is there a problem in screenshot

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Sep 17, 2023 •
edited
Loading

@abhijeetgauravm image

Ohh you r suppose to add the screenshots to the Azure Active Directory (AAD) according to the issue for which u raised PR but it seems like u added to the Akri integration.

@abhijeetgauravm
Copy link
Contributor

abhijeetgauravm commented Sep 17, 2023 •
edited
Loading

But @PRANJALRANA11 No sweat u comment on this issue for assignment #4830 . And mention this issue #4830 u r fixing in your current PR. And if u wanna raise another PR for the current issue Azure Active Directory (AAD) u can!

@PRANJALRANA11
Copy link
Contributor Author

@abhijeetgauravm oh ok I got it sorry for inconvenience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhijeetgauravm abhijeetgauravm abhijeetgauravm requested changes

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Assignees
No one assigned
Labels
project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshots] Azure Active Directory (AAD) under "How it Works See It in Action” section
4 participants
@PRANJALRANA11 @l5io @Ghat0tkach @abhijeetgauravm