Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screenshots] CRI-O under 'How it Works See It in Action' section #4990

Merged
merged 4 commits into from
Jan 26, 2024
Merged

[Screenshots] CRI-O under 'How it Works See It in Action' section #4990

merged 4 commits into from
Jan 26, 2024

Conversation

coder12git
Copy link
Member

Description

This PR fixes #4881

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@coder12git
Added screenshots
28404f2 
Signed-off-by: coder12git <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 1, 2023

🚀 Preview for commit 28404f2 at: https://6519caa911d6340301a79a75--layer5.netlify.app

@abhijeetgauravm
Copy link
Contributor

Let's discuss this Item in today's website call,
Please add it as your agenda if you would:
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit

@coder12git
Copy link
Member Author

Let's discuss this Item in today's website call, Please add it as your agenda if you would: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit

@abhijeetgauravm but the issue was resolved, I don't think now I have any issue

sandramsc
sandramsc suggested changes Oct 12, 2023
View reviewed changes
Copy link
Member

@sandramsc sandramsc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @coder12git , thank you for your contribution, the visualizer screenshot is missing icons on the canvas, please upload a new one. See the comment/screenshot on this PR for visual context and entire PR for overall context.

@coder12git
modified screenshots
cec976c 
Signed-off-by: coder12git <[email protected]>
@coder12git
Copy link
Member Author

Hi @coder12git , thank you for your contribution, the visualizer screenshot is missing icons on the canvas, please upload a new one. See the comment/screenshot on this PR for more context.

@sandramsc it's done!

@l5io
Copy link
Contributor

l5io commented Oct 12, 2023

🚀 Preview for commit cec976c at: https://65282c1edbaa8e4e86cd27dc--layer5.netlify.app

@singh1203 singh1203 mentioned this pull request Oct 13, 2023
Closed
1 task
@sudhanshutech
Copy link
Member

@coder12git merge conflict

@l5io
Copy link
Contributor

l5io commented Jan 26, 2024

🚀 Preview for commit 63eb5ed at: https://65b3c4645a91911d1574d002--layer5.netlify.app

@iArchitSharma
restructure
dff2720 
Signed-off-by: Archit Sharma <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jan 26, 2024

🚀 Preview for commit dff2720 at: https://65b3c7bbfdec1d19ddcf0599--layer5.netlify.app

@iArchitSharma iArchitSharma merged commit 924fcfc into layer5io:master Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandramsc sandramsc sandramsc requested changes

@saurabh100ni saurabh100ni Awaiting requested review from saurabh100ni

Assignees
No one assigned
Labels
project/meshery
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Screenshots] CRI-O under 'How it Works See It in Action' section
6 participants
@coder12git @l5io @abhijeetgauravm @sudhanshutech @sandramsc @iArchitSharma