Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update screen shots #4985

Merged
merged 2 commits into from
Nov 29, 2023
Merged

update screen shots #4985

merged 2 commits into from
Nov 29, 2023

Conversation

ShatilKhan
Copy link
Contributor

Description

This PR fixes #4885

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: ShatilKhan <[email protected]>
@sandramsc
Copy link
Member

sandramsc commented Sep 29, 2023

Hi @ShatilKhan there are two checks that are currently failing, taking a quick look at the changed files I noticed that you've removed the old images and added the new ones. This might be the cause. Consider taking a look at this comment, which might give a bit more visual context and entire PR for overall context.

Signed-off-by: ShatilKhan <[email protected]>
@ShatilKhan
Copy link
Contributor Author

Thanks @sandramsc !
I've restored the images!

@l5io
Copy link
Contributor

l5io commented Sep 29, 2023

🚀 Preview for commit 4c4230b at: https://6516f84d5ef5ac07873b34fb--layer5.netlify.app

@ShatilKhan
Copy link
Contributor Author

Preview image:
image

@sandramsc
Copy link
Member

sandramsc commented Sep 29, 2023

@ShatilKhan, after taking a look at the vizualier screenshot it appears that the icons are missing on the canvas. Consider retaking a new one.

@saurabh100ni
Copy link
Contributor

Let's discuss this Item in tomorrow's website call,
please add it as your agenda if you would:
https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit

@ritiksaxena124
Copy link
Contributor

Any update on this @ShatilKhan ?

@ShatilKhan
Copy link
Contributor Author

Will submit updates by tonight

@ShatilKhan
Copy link
Contributor Author

Guys, facing some issues
I only get the option to clone. The design isn't immediately appearing , is this some new feature update? I didn't see this before & don't understand how to initiate this design into my meshmap
image

@Harsha-10
Copy link
Contributor

Change the filter in designs from published to public, then they will show up in canvas

@leecalcote
Copy link
Member

Change the filter in designs from published to public, then they will show up in canvas

@Harsha-10 you're right!

In fact, this area has improved and now there is a dedicated tab menu for Catalog (published) vs Designs (private, public)

@leecalcote leecalcote merged commit a9bca11 into layer5io:master Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Screenshots] Dapr under 'How it Works See It in Action' section
7 participants