Skip to content

chore: use combined @tsconfig/bases package#526

Merged
nicknovitski merged 1 commit intomainfrom
tsconfig-bases
Mar 11, 2026
Merged

chore: use combined @tsconfig/bases package#526
nicknovitski merged 1 commit intomainfrom
tsconfig-bases

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Mar 10, 2026

Why

Eh, just one fewer dependency. I don't see much advantage of updating each @tsconfig package separately.

Test Plan

Besides everything else I decided to diff the output of tsc -showConfig before and after this commit, and they were identical.

@nicknovitski nicknovitski marked this pull request as ready for review March 10, 2026 00:37
@nicknovitski nicknovitski requested a review from wschurman as a code owner March 10, 2026 00:37
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (81906ae) to head (0437ec0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##             main      #526       +/-   ##
============================================
+ Coverage   25.57%   100.00%   +74.42%     
============================================
  Files         110       110               
  Lines       16718     16718               
  Branches      340      1519     +1179     
============================================
+ Hits         4275     16718    +12443     
+ Misses      12362         0    -12362     
+ Partials       81         0       -81     
Flag Coverage Δ
integration 25.57% <ø> (ø)
unittest 94.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski force-pushed the tests-node-types branch 2 times, most recently from ddb6220 to 9b8b836 Compare March 10, 2026 16:54
@nicknovitski nicknovitski changed the base branch from tests-node-types to graphite-base/526 March 10, 2026 17:25
Copy link
Member Author

nicknovitski commented Mar 11, 2026

Merge activity

  • Mar 11, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 11, 3:26 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 11, 3:29 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski changed the base branch from graphite-base/526 to esm-tests March 11, 2026 15:25
@nicknovitski nicknovitski changed the base branch from esm-tests to graphite-base/526 March 11, 2026 15:25
@nicknovitski nicknovitski changed the base branch from graphite-base/526 to main March 11, 2026 15:25
@nicknovitski nicknovitski merged commit 090c046 into main Mar 11, 2026
6 checks passed
@nicknovitski nicknovitski deleted the tsconfig-bases branch March 11, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants