Skip to content

chore: use @expo/nullthrows in tests#517

Merged
nicknovitski merged 1 commit intomainfrom
expo-nullthrows
Mar 10, 2026
Merged

chore: use @expo/nullthrows in tests#517
nicknovitski merged 1 commit intomainfrom
expo-nullthrows

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Mar 9, 2026

Why

This package is slightly newer and is usable with ESM.

How

Drop-in replacement.

Test Plan

We only use it in tests, so I ran those tests.

transform: { '\\.[jt]sx?$': ['babel-jest', { rootMode: 'upward' }] },
// ESM modules that need to be transformed
transformIgnorePatterns: ['node_modules/(?!(uuid)/)'],
transformIgnorePatterns: ['node_modules/(?!(uuid|@expo)/)'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to be more specific. I believe this relies upon a number of @expo packages (batcher, results).

Copy link
Member Author

nicknovitski commented Mar 10, 2026

Merge activity

  • Mar 10, 12:37 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 10, 12:37 AM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski merged commit 1aae31b into main Mar 10, 2026
5 checks passed
@nicknovitski nicknovitski deleted the expo-nullthrows branch March 10, 2026 00:37
@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (9202ecb) to head (33eeee2).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #517    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          110       110            
  Lines        16708     16708            
  Branches       915      1519   +604     
==========================================
  Hits         16708     16708            
Flag Coverage Δ
integration 25.58% <0.00%> (ø)
unittest 94.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants