Skip to content

chore: generate barrel files with file endings#520

Merged
nicknovitski merged 1 commit intomainfrom
barrel-ts-file-endings
Mar 11, 2026
Merged

chore: generate barrel files with file endings#520
nicknovitski merged 1 commit intomainfrom
barrel-ts-file-endings

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Mar 9, 2026

Why

ESM requires all relative imports to have file endings.

How

Added a ctix config option and ran the build. Thanks to the rewriteRelativeImport tsconfig setting, these .ts file endings will be built into .js ones.

Test Plan

Run yarn test, which builds everything first, and trust that many packages import the built entity indices for their tests.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f75ed7f) to head (2fce77c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        16711     16711           
  Branches      1506      1519   +13     
=========================================
  Hits         16711     16711           
Flag Coverage Δ
integration 25.55% <ø> (ø)
unittest 94.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski force-pushed the barrel-ts-file-endings branch from 00dae60 to 1005e99 Compare March 10, 2026 16:47
@nicknovitski nicknovitski force-pushed the allow-ts-imports branch 2 times, most recently from 33623fd to cc136a7 Compare March 10, 2026 16:52
@nicknovitski nicknovitski force-pushed the barrel-ts-file-endings branch 2 times, most recently from 2df2bfe to 88b3f09 Compare March 10, 2026 17:00
Copy link
Member Author

nicknovitski commented Mar 11, 2026

Merge activity

  • Mar 11, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 11, 3:12 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 11, 3:14 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski changed the base branch from allow-ts-imports to graphite-base/520 March 11, 2026 15:11
@nicknovitski nicknovitski changed the base branch from graphite-base/520 to main March 11, 2026 15:11
@nicknovitski nicknovitski force-pushed the barrel-ts-file-endings branch from 88b3f09 to 2fce77c Compare March 11, 2026 15:12
@nicknovitski nicknovitski merged commit e4133a8 into main Mar 11, 2026
4 checks passed
@nicknovitski nicknovitski deleted the barrel-ts-file-endings branch March 11, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants