Skip to content

chore: run jest without babel#524

Draft
nicknovitski wants to merge 1 commit intographite-base/524from
tests-node-types
Draft

chore: run jest without babel#524
nicknovitski wants to merge 1 commit intographite-base/524from
tests-node-types

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Mar 9, 2026

Why

Weeeell in the abstract fewer dependencies is good, also it does speed up the unit tests about 40%.

How

Replace the packages with a simple local file using node:module.

Test Plan

All the tests run good, locally. Why isn't CI doing the same thing??

Copy link
Member Author

nicknovitski commented Mar 9, 2026

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (6308316) to head (a56cfe3).

Additional details and impacted files
@@             Coverage Diff             @@
##           esm-tests      #524   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files            110       110           
  Lines          16718     16718           
  Branches        1519      1514    -5     
===========================================
  Hits           16718     16718           
Flag Coverage Δ
integration 25.42% <ø> (-0.15%) ⬇️
unittest 94.95% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski force-pushed the esm-tests branch 2 times, most recently from 3dd55f8 to ef980cc Compare March 10, 2026 16:53
@nicknovitski nicknovitski force-pushed the tests-node-types branch 2 times, most recently from 9b8b836 to 64e4381 Compare March 10, 2026 17:00
@nicknovitski nicknovitski marked this pull request as draft March 10, 2026 17:23
@nicknovitski nicknovitski changed the base branch from esm-tests to graphite-base/524 March 10, 2026 17:25
@nicknovitski nicknovitski removed the request for review from wschurman March 10, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant