Skip to content

chore: Run tests with ESM#523

Merged
nicknovitski merged 1 commit intomainfrom
esm-tests
Mar 11, 2026
Merged

chore: Run tests with ESM#523
nicknovitski merged 1 commit intomainfrom
esm-tests

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Mar 9, 2026

Why

Consistency, and for the hope of removing babel in my next PR.

How

Replace some __dirname usage (I had to rewrite the codemod tests). Add "type": "module" to the root package.json and update some configuration.

Test Plan

Ran the tests! Especially the new codemod ones.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ea9c45f) to head (e22184a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #523    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          110       110            
  Lines        16718     16718            
  Branches       902      1519   +617     
==========================================
  Hits         16718     16718            
Flag Coverage Δ
integration 25.57% <100.00%> (ø)
unittest 94.95% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

nicknovitski commented Mar 11, 2026

Merge activity

  • Mar 11, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 11, 3:23 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 11, 3:25 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski changed the base branch from use-lodash-es to graphite-base/523 March 11, 2026 15:18
@nicknovitski nicknovitski changed the base branch from graphite-base/523 to main March 11, 2026 15:21
@nicknovitski nicknovitski merged commit 81906ae into main Mar 11, 2026
6 checks passed
@nicknovitski nicknovitski deleted the esm-tests branch March 11, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants