Skip to content

chore: replace lodash with lodash-es#522

Merged
nicknovitski merged 1 commit intomainfrom
use-lodash-es
Mar 11, 2026
Merged

chore: replace lodash with lodash-es#522
nicknovitski merged 1 commit intomainfrom
use-lodash-es

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Mar 9, 2026

Why

This is what esm consumers are supposed to do, and it's required to run jest with ESM.

How

Drop-in replacement.

Test Plan

Ran all the ci checks.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2fc88cb) to head (1cf45aa).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #522   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines        16718     16718           
  Branches      1519      1519           
=========================================
  Hits         16718     16718           
Flag Coverage Δ
integration 25.57% <ø> (ø)
unittest 94.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member Author

nicknovitski commented Mar 11, 2026

Merge activity

  • Mar 11, 3:10 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 11, 3:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 11, 3:21 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski changed the base branch from esm to graphite-base/522 March 11, 2026 15:15
@nicknovitski nicknovitski changed the base branch from graphite-base/522 to main March 11, 2026 15:17
@nicknovitski nicknovitski merged commit ea9c45f into main Mar 11, 2026
6 checks passed
@nicknovitski nicknovitski deleted the use-lodash-es branch March 11, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants