chore: allow relative imports with ts file extension#519
Merged
nicknovitski merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Member
Author
This was referenced Mar 9, 2026
Merged
d05972f to
5bb3960
Compare
b2030ff to
f008ff8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 16711 16711
Branches 1519 1519
=========================================
Hits 16711 16711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f008ff8 to
ae9b691
Compare
5bb3960 to
a6e75d0
Compare
ae9b691 to
575d854
Compare
a6e75d0 to
33623fd
Compare
33623fd to
cc136a7
Compare
wschurman
approved these changes
Mar 11, 2026
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
ESM requires relative imports to have file endings. New versions of typescript finally allow us to write source files with imports ending in
.tsand get built files with imports ending in.js. If you runnode --experimental-transform-typeson a file, it will treat the import paths as they're written, so typescript source files need to be importing their typescript siblings.With this enabled, we can run node with strip- or transform-types on the source files, and run
tscto get correctly built output with.jsimports.How
Just added the setting. See other PRs in the stack for changes which depend on this.
Test Plan
No changes to source.