Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Request] Limit incidents returned from large query #132

Merged
merged 12 commits into from
Jun 10, 2022

Conversation

giranm
Copy link
Owner

@giranm giranm commented Jun 10, 2022

Summary

This PR closes #127 which addresses a fundamental user journey of large incidents being queried.
Kindly note the following changes:

  • A pre-check API call is done to determine if the query will return more than the configured limit of 200 incidents.
  • We display a confirmation modal whether to continue or reject the query (if over the limit)
  • An additional debounce mechanism is added to consolidate query filters updates
    (e.g. wait 2 seconds until all query changes have been completed before doing pre-check API call)
  • Refactored relevant components into their separate sub-components and added test coverage.
  • Introduced mocks for incident object with a subset of fields; this can be improved on in a future PR.
  • Fixed e2e test for querying acknowledged incidents (i.e. fixing AWS Amplify test runs)

NB - pdParallelFetch will still fetch the original dataset - we aim to patch this in a future PR with including @martindstone's pagerduty-cli code for limiting data fetch.

Video

Screen.Recording.2022-06-10.at.16.10.27.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Change Request fix Fix bug/issue task Housekeeping tasks to improve code base
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Change Request] Restrict total number of incidents returned from query
1 participant