Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Inconsistent incidents when filtered by escalation policy compared to teams #302

Open
giranm opened this issue Oct 13, 2022 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@giranm
Copy link
Owner

giranm commented Oct 13, 2022

Summary

There have been reports of inconsistent filtering of incidents by escalation policy compared to teams within PD Live.
e.g. filtering by EP "Team A" (associated with Team A) shows different results than filtering from Team "Team A" itself.

This feature was introduced under #263 but may also be related to ongoing bug #175.

@giranm giranm added the bug Something isn't working label Oct 13, 2022
@giranm giranm added this to the Beta milestone Oct 13, 2022
@giranm giranm moved this to Triage in PagerDuty Live Oct 13, 2022
@giranm
Copy link
Owner Author

giranm commented Oct 26, 2022

For some additional context, the PD REST API for GET /incidents only allows you to do server side querying based on:

  • Statuses
  • Urgencies
  • Service IDs
  • Team IDs
  • User IDs

Prior to the introduction of the alerts data in view (#137), we used to fetch the entire incident dataset (for the given query up to 10,000 records), then apply the truncation and post-filtering (priorities only supported at that time).

In order to support alerts data in the view (consuming a separate API call PER incident), we implemented the hard max incidents limit - initially 200 (#132), then set to a configurable limit up to 1000 (#143) - in order to ensure that users were within the API rate limits of 2000 API calls per minute.

On reflection of this issue, it would appear that this underlying behaviour has always existed since the inclusion of the alerts data enhancement, but only became visible when the introduction of EP was introduced (#263).
e.g. using EP as a substitution for team filtering.

Given this - there are two possible solutions here:

  • Reintroduce fetch of 10,000 incidents, apply local filters, then truncate dataset on maxIncidentsLimit, to ensure we're not missing any incidents outside of API query.
  • Raise core product enhancement with PagerDuty Engineering to support priority_ids[] and escalation_policy_ids[] in the query parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Triage
Development

No branches or pull requests

1 participant