Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Request] Restrict total number of incidents returned from query #127

Closed
giranm opened this issue Jun 4, 2022 · 1 comment · Fixed by #132
Closed

[Change Request] Restrict total number of incidents returned from query #127

giranm opened this issue Jun 4, 2022 · 1 comment · Fixed by #132
Labels
change request Change Request fix Fix bug/issue task Housekeeping tasks to improve code base
Milestone

Comments

@giranm
Copy link
Owner

giranm commented Jun 4, 2022

Summary

This ticket has been raised on reports of HTTP 429 errors within PD Live.
It has been noted that some users are trying to pull large historical datasets which PD Live was not designed/intended for.

Specifically, this occurs under the following user behaviours:

  • Query by long since date (i.e. too many open incidents)
  • Query by resolved incidents (i.e. show me everything)

The current implementation of PD Live will initially fetch incident data in parallel, then do batched calls for the incident notes.
When users decide to update the query upon mid-fetch, then additional API calls are made which exceed the rate limit, ultimately leading to HTTP 429 errors and empty/missing data in the UI.

Proposed Change

To prevent HTTP 429 errors, we have proposed the following:

Implementing these changes should also address #77 and #92 given the fixed number of incidents in view.

@giranm giranm added task Housekeeping tasks to improve code base fix Fix bug/issue change request Change Request labels Jun 4, 2022
@giranm giranm added this to the Beta milestone Jun 4, 2022
@giranm giranm moved this to In Progress in PagerDuty Live Jun 5, 2022
@giranm giranm linked a pull request Jun 10, 2022 that will close this issue
@giranm giranm moved this from In Progress to Code Review in PagerDuty Live Jun 10, 2022
@giranm
Copy link
Owner Author

giranm commented Jun 13, 2022

PR #132 has been merged to develop - closing ticket.

@giranm giranm closed this as completed Jun 13, 2022
Repository owner moved this from Code Review to Done in PagerDuty Live Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change request Change Request fix Fix bug/issue task Housekeeping tasks to improve code base
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant