Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Change Request] Add auto-confirmation setting for incident query modal #193

Closed
giranm opened this issue Aug 5, 2022 · 1 comment · Fixed by #198
Closed

[Change Request] Add auto-confirmation setting for incident query modal #193

giranm opened this issue Aug 5, 2022 · 1 comment · Fixed by #198
Labels
change request Change Request
Milestone
Beta

Comments

@giranm
Copy link
Owner

giranm commented Aug 5, 2022

Summary

#132 introduced a change to hardcode a maximum limit of 200 incidents retrieved by the UI.
For some users, changing the query and accepting the modal each time can be very tiresome.

Proposed Changes

  • Add boolean setting under User Profile to auto-accept incidents over MAX_INCIDENTS_LIMIT
  • Update validateIncidentQueryImpl to dispatch CONFIRM_INCIDENT_QUERY_REQUESTED conditional on above setting

    pd-live-react/src/redux/query_settings/sagas.js

    Line 219 in a8c2f41

    if (totalIncidentsFromQuery > MAX_INCIDENTS_LIMIT) {
@giranm giranm added the change request Change Request label Aug 5, 2022
@giranm giranm added this to the Beta milestone Aug 5, 2022
@giranm giranm moved this to In Progress in PagerDuty Live Aug 6, 2022
@giranm giranm mentioned this issue Aug 7, 2022
Merged
@giranm giranm moved this from In Progress to Code Review in PagerDuty Live Aug 7, 2022
@giranm giranm linked a pull request Aug 7, 2022 that will close this issue
[Change Request] Update incident fetch behaviours #198
Merged
@giranm giranm moved this from Code Review to Done in PagerDuty Live Aug 7, 2022
@giranm
Copy link
Owner Author

giranm commented Aug 7, 2022

Merged #198 into develop - closing.

@giranm giranm closed this as completed Aug 7, 2022
@giranm giranm mentioned this issue Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change request Change Request
Projects
PagerDuty Live
Status: Done
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

[Change Request] Update incident fetch behaviours giranm/pd-live-react
1 participant
@giranm