Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Update Cypress Tests for Query.spec.js #156

Closed
giranm opened this issue Jul 22, 2022 · 1 comment · Fixed by #222
Closed

[Task] Update Cypress Tests for Query.spec.js #156

giranm opened this issue Jul 22, 2022 · 1 comment · Fixed by #222
Labels
bug Something isn't working task Housekeeping tasks to improve code base
Milestone

Comments

@giranm
Copy link
Owner

giranm commented Jul 22, 2022

Summary

Since introduction of change request #132, we have added a 2000ms debounce when any of the query filters have been updated. Although this gives users a chance to update their filters in quick succession (without exhausting API calls), this may be the cause of why some of the integration tests are failing.

Example failed run: https://github.com/giranm/pd-live-react/runs/7467993657?check_suite_focus=true#step:7:75

Proposed Fix

Introduce a 2000ms wait on waitForIncidentTable() under cypress/support/util/common.js before the incident table element is queried. This should give enough time for PD Live to call the API and to re-render the correct data.

@giranm giranm added bug Something isn't working task Housekeeping tasks to improve code base labels Jul 22, 2022
@giranm giranm added this to the Beta milestone Jul 22, 2022
@giranm giranm moved this to Todo in PagerDuty Live Jul 25, 2022
@giranm giranm linked a pull request Aug 13, 2022 that will close this issue
@giranm giranm moved this from Todo to Code Review in PagerDuty Live Aug 13, 2022
@giranm
Copy link
Owner Author

giranm commented Aug 13, 2022

PR #222 has been merged - closing.

@giranm giranm closed this as completed Aug 13, 2022
Repository owner moved this from Code Review to Done in PagerDuty Live Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task Housekeeping tasks to improve code base
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant