[Change Request] Increase limit of incidents available upon request

[giranm]

Summary

#132 introduced a change to hardcode a maximum limit of 200 incidents retrieved by the UI.

pd-live-react/src/config/constants.js

Line 27 in a8c2f41

export const MAX_INCIDENTS_LIMIT = 200;

The intention of this change was to ensure that users don't hit PagerDuty's API rate limit (HTTP 429 errors), which yielded empty data in the incident table.

Upon introduction of enhancement #131, we are also retrieving all alerts for each incident, resulting in a total of 2X + X/100 API calls per X number of incidents - effectively increasing the number of API calls done.

To put this into user perspective, querying 200 incidents takes approximately 40 seconds to populate in the UI, including notes and alert data.

Proposed Changes

There are a couple of options we can address here - ultimately it depends on what the optimal user experience would be:

• Expose MAX_INCIDENTS_LIMIT as an environment variable
• Make MAX_INCIDENTS_LIMIT a user configurable setting, which is more desirable for individual users

Challenges

Increasing MAX_INCIDENTS_LIMIT increases the number of API calls needed on the initial fetch; large number of incidents will need further throttling and take much longer to populate in the UI.

[giranm]

Merged #198 into develop - closing.