feat(bay): focus the crustacean finder with the / shortcut by steipete · Pull Request #1182 · openclaw/clawsweeper

steipete · 2026-08-17T06:37:07Z

Summary

Pressing / anywhere outside a form control now focuses the Bay finder ("Where's my crustacean?"), matching the common search-shortcut convention, and the finder hint advertises it ("press /").

Behavior

/ focuses the search input unless typing in an input, textarea, select, or contenteditable element, and never with a modifier held.
The hint text under the finder now reads "Search the visible public references · press /" (also after Clear).

Proof

pnpm build clean on the branch head.
The change is three lines in dashboard/bay-page.ts (hint text in two places plus one delegated keydown listener); the bay routes test asserting the finder markup still passes.

Pressing / anywhere outside a form control focuses the Bay search box, and the finder hint advertises the shortcut.

clawsweeper · 2026-08-17T06:37:10Z

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

clawsweeper · 2026-08-17T06:40:18Z

Codex review: needs maintainer review before merge. Reviewed August 18, 2026, 4:52 AM ET / 08:52 UTC.

ClawSweeper review

What this changes

The PR adds a guarded / keyboard shortcut for focusing the OpenClaw Bay public-reference finder and advertises it in the finder hint.

Merge readiness

⚠️ Ready for maintainer review - 2 items remain

Keep open: the shortcut is still absent from current main, and the linked live-proof follow-up records a successful after-fix focus check, but this head is dirty and conflicts with current Bay changes. Likely related people: Martin Cleary (high confidence).

Priority: P3
Reviewed head: a34b5e1c78de3986e37bd0e95598f295ef4d335b

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	The focused implementation and after-fix focus evidence are sound, but the branch needs a clean rebase before it can be landed.
Proof confidence	🐚 platinum hermit (4/6)	Sufficient (logs): The linked merged live-proof follow-up records a successful after-fix `/` keypress and `#finder-input:focus` observation on this PR head.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Verified	Sufficient (logs): The linked merged live-proof follow-up records a successful after-fix `/` keypress and `#finder-input:focus` observation on this PR head.
Evidence reviewed	5 items	PR implementation: The PR head adds the finder hint and a delegated keydown guard that ignores modifier keys and editable form targets before focusing the finder. Current-main comparison: Current main retains the finder but has no delegated slash-key handler, so the requested behavior is not already implemented. Merge conflict: A three-way merge against the PR base produces a conflict in the same Bay script block containing finder behavior and listeners; GitHub also reports the PR as dirty.
Findings	None	None.
Security	None	None.

Live Verification

Entry: /bay

Result: PASS (completed)

Steps:

PASS goto /bay
PASS wait_for #finder-input
PASS press /
PASS wait_for #finder-input:focus

How this fits together

OpenClaw Bay is the public, observer-only dashboard for verified GitHub work. Browser input is filtered by the finder and then used to locate a reference in the currently visible public sample.

flowchart LR
A[Browser keypress] --> B[Shortcut guard]
B --> C[Bay finder]
C --> D[Visible public references]
D --> E[Focused matching item]

Before merge

Resolve merge risk (P1) - The current head cannot merge cleanly; rebasing must preserve main’s newer Bay listener and public-projection behavior before the shortcut can land.
Complete next step (P2) - The PR’s current head is merge-conflicted, so its author should rebase and refresh review evidence rather than sending an automated repair worker.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Patch scope	1 file changed; 3 added, 3 removed	The requested enhancement is narrowly contained in the Bay page, but that dense script has since changed and needs a conflict-aware rebase.

Merge-risk options

Maintainer options:

Decide the mitigation before merge
Rebase the narrowly guarded shortcut onto current main, resolve the Bay-script conflict without discarding current behavior, and retain the existing live focus proof for the rebased head.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Technical review

Best possible solution:

Rebase the narrowly guarded shortcut onto current main, resolve the Bay-script conflict without discarding current behavior, and retain the existing live focus proof for the rebased head.

Do we have a high-confidence way to reproduce the issue?

Not applicable as a bug reproduction: this is a usability enhancement, and the related live-proof record already exercised / and observed finder focus on the PR head.

Is this the best way to solve the issue?

Yes, after rebasing: a modifier- and editable-target-aware document listener is a narrow way to add this conventional finder shortcut without altering Bay’s data flow.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 33ef24274870.

Labels

Label changes:

add proof: sufficient: Contributor real behavior proof is sufficient. The linked merged live-proof follow-up records a successful after-fix / keypress and #finder-input:focus observation on this PR head.
add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (logs): The linked merged live-proof follow-up records a successful after-fix / keypress and #finder-input:focus observation on this PR head.
remove rating: 🧂 unranked krab: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.
remove status: 📣 needs proof: Current PR status label is status: 👀 ready for maintainer look.

Label justifications:

P3: This is a small, non-blocking Bay usability enhancement.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🐚 platinum hermit.
status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (logs): The linked merged live-proof follow-up records a successful after-fix / keypress and #finder-input:focus observation on this PR head.
proof: sufficient: Contributor real behavior proof is sufficient. The linked merged live-proof follow-up records a successful after-fix / keypress and #finder-input:focus observation on this PR head.

Evidence

What I checked:

PR implementation: The PR head adds the finder hint and a delegated keydown guard that ignores modifier keys and editable form targets before focusing the finder. (dashboard/bay-page.ts:368, a34b5e1c78de)
Current-main comparison: Current main retains the finder but has no delegated slash-key handler, so the requested behavior is not already implemented. (dashboard/bay-page.ts:374, 33ef24274870)
Merge conflict: A three-way merge against the PR base produces a conflict in the same Bay script block containing finder behavior and listeners; GitHub also reports the PR as dirty. (dashboard/bay-page.ts:374, 33ef24274870)
Feature history: Current-main history shows Martin Cleary repeatedly maintaining the Bay page, most recently through the public-projection repair. (dashboard/bay-page.ts:370, 335cb45ceb16)
After-fix behavior proof: The merged live-proof follow-up fix(live-proof): install the target toolchain and assert satisfiable values #1206 records that pressing / and waiting for #finder-input:focus both passed against this PR head. (dashboard/bay-page.ts:368, 33ef24274870)

Likely related people:

Martin Cleary: Recent current-main history contains the Bay public-projection repair and several preceding Bay feature and compatibility changes. (role: recent Bay contributor; confidence: high; commits: 335cb45ceb16, 68a6dfcfc556, db26b72b3b73; files: dashboard/bay-page.ts)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

Rebase onto current main, resolve the Bay-script conflict, and refresh the PR body and review for the resulting head.

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (4 earlier review cycles)

reviewed 2026-08-17T12:39:53.169Z sha a34b5e1 :: needs real behavior proof before merge. :: none
reviewed 2026-08-18T02:59:48.960Z sha a34b5e1 :: needs real behavior proof before merge. :: none
reviewed 2026-08-18T05:23:37.903Z sha a34b5e1 :: needs real behavior proof before merge. :: none
reviewed 2026-08-18T08:14:20.558Z sha a34b5e1 :: needs real behavior proof before merge. :: none

…ests everywhere (#1184) The exact-event review lane delivers GitHub effects directly and skips the artifact publication job, so its recommended live proofs never dispatched (observed on #1182, run 32002395638). Both lanes now share a repair-built candidates CLI, which the conditional build-script emits in every branch, and dispatch with a host-repo app token. live_test is now inherited from generic fallback profiles, enabling terminal-surface live proofs for every openclaw/* and steipete/* target (including openclaw/openclaw), with browser configs for ClawHub and the ClawSweeper bay demo. A recommended browser plan for a terminal-only repository is a logged skip instead of an error.

steipete · 2026-08-17T08:18:51Z

@clawsweeper re-review

clawsweeper · 2026-08-17T08:18:56Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32011417228
Updated: 2026-08-17T08:40:01.889Z

steipete · 2026-08-17T09:47:49Z

@clawsweeper re-review

clawsweeper · 2026-08-17T09:47:51Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32017290725
Updated: 2026-08-17T09:51:32.431Z

steipete · 2026-08-17T12:37:11Z

@clawsweeper re-review

clawsweeper · 2026-08-17T12:37:15Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32031613631
Updated: 2026-08-17T12:47:38.499Z

…1198) The attach job hydrates the CURRENT record straight from the canonical store, but repair:publish-main fell back to the intentionally unhydrated CLAWSWEEPER_STATE_DIR for its three-way baseline, so every publication looked like a same-section concurrent edit and conflicted deterministically (#1182 run 32031655761). Each retry attempt now captures the freshly hydrated record as an explicit baseline for the unchanged strict fence, matching exact review's capture-before-mutate idiom.

steipete · 2026-08-18T02:57:11Z

@clawsweeper re-review

clawsweeper · 2026-08-18T02:57:14Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32094402162
Updated: 2026-08-18T03:08:57.518Z

steipete · 2026-08-18T05:20:30Z

@clawsweeper re-review

clawsweeper · 2026-08-18T05:20:38Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32103333135
Updated: 2026-08-18T05:33:36.543Z

steipete · 2026-08-18T08:11:41Z

@clawsweeper re-review

clawsweeper · 2026-08-18T08:11:44Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32115831371
Updated: 2026-08-18T08:20:14.814Z

steipete · 2026-08-18T08:45:59Z

@clawsweeper re-review

clawsweeper · 2026-08-18T08:46:06Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event exact_review_queue).
Result: when the review finishes, ClawSweeper will create the durable review comment if needed or update the existing comment in place.

Re-review progress:

State: Complete
Detail: The durable review result and its route handoff completed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/32119668456
Updated: 2026-08-18T09:04:46.621Z

feat(bay): focus the crustacean finder with the / shortcut

a34b5e1

Pressing / anywhere outside a form control focuses the Bay search box, and the finder hint advertises the shortcut.

steipete mentioned this pull request Aug 17, 2026

fix(live-proof): dispatch from the exact-event lane and enable live tests everywhere #1184

Merged

clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Aug 17, 2026

steipete mentioned this pull request Aug 17, 2026

fix(live-proof): publish against an attempt-scoped hydrated baseline #1198

Merged

This was referenced Aug 18, 2026

fix(live-proof): only publish recordings that demonstrate a change #1199

Merged

feat(live-proof): retract a published recording with detach mode #1200

Merged

feat(live-proof): retract published recordings from workflow dispatch #1201

Merged

clawsweeper Bot added rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. and removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. labels Aug 18, 2026

clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. and removed rating: 🦪 silver shellfish Thin PR readiness signal; proof, validation, or implementation needs work. labels Aug 18, 2026

steipete mentioned this pull request Aug 18, 2026

fix(live-proof): install the target toolchain and assert satisfiable values #1206

Merged

Uh oh!

Conversation

steipete commented Aug 17, 2026

Summary

Behavior

Proof

Uh oh!

clawsweeper Bot commented Aug 17, 2026

Uh oh!

clawsweeper Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ClawSweeper review

What this changes

Merge readiness

Review scores

Verification

Live Verification

How this fits together

Before merge

Security

Review metrics

Merge-risk options

Technical review

Labels

Evidence

Rank-up moves

Rating scale

Workflow

History

Uh oh!

steipete commented Aug 17, 2026

Uh oh!

clawsweeper Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Aug 17, 2026

Uh oh!

clawsweeper Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Aug 17, 2026

Uh oh!

clawsweeper Bot commented Aug 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Aug 18, 2026

Uh oh!

clawsweeper Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Aug 18, 2026

Uh oh!

clawsweeper Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Aug 18, 2026

Uh oh!

clawsweeper Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

steipete commented Aug 18, 2026

Uh oh!

clawsweeper Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Aug 17, 2026 •

edited

Loading

clawsweeper Bot commented Aug 17, 2026 •

edited

Loading

clawsweeper Bot commented Aug 17, 2026 •

edited

Loading

clawsweeper Bot commented Aug 17, 2026 •

edited

Loading

clawsweeper Bot commented Aug 18, 2026 •

edited

Loading

clawsweeper Bot commented Aug 18, 2026 •

edited

Loading

clawsweeper Bot commented Aug 18, 2026 •

edited

Loading

clawsweeper Bot commented Aug 18, 2026 •

edited

Loading