fix(live-proof): publish against an attempt-scoped hydrated baseline - #1198
Merged
Conversation
The attach job hydrates the CURRENT record straight from the canonical store, but repair:publish-main fell back to the intentionally unhydrated CLAWSWEEPER_STATE_DIR for its three-way baseline, so every publication looked like a same-section concurrent edit and conflicted deterministically (#1182 run 32031655761). Each retry attempt now captures the freshly hydrated record as an explicit baseline for the unchanged strict fence, matching exact review's capture-before-mutate idiom.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): publish against an attempt-scoped hydrated baseline This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The attach conflict was systematic, not churn: #1182 (a record with no concurrent writers) conflicted on all three retry attempts (run 32031655761). Investigation refuted the snapshot-lag hypothesis — focused hydration reads CURRENT straight from the Durable Object canonical store — and found the real cause:
repair:publish-mainfell back to the intentionally unhydratedCLAWSWEEPER_STATE_DIRfor its three-way baseline, so the absent/stale expected digest made every publication look like a same-section concurrent edit.Each retry attempt now captures the freshly hydrated record into an attempt-scoped baseline and supplies it explicitly to the unchanged strict publisher fence, matching exact review's capture-before-mutate idiom.
Validation
pnpm buildclean; focused suites 38/38; publish-main suite 15/15; full unit 2,311 passed, 0 failed.