feat(live-proof): retract a published recording with detach mode - #1200
Merged
Conversation
Recordings that demonstrate nothing are now refused before publication, but that cannot remove blocks already written to durable records, and the marker-backed comment is re-rendered from the record so junk persists. live-proof-attach --detach removes only the recording block, keeps the plan, is idempotent when no block exists, works after the head moves, and reuses the hydrated-baseline publish with comment sync after publication.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat(live-proof): retract a published recording with detach mode This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#1199 stopped the lane from publishing recordings that demonstrate nothing, but it cannot remove blocks already written to durable records — and because the marker-backed comment is re-rendered from the record, the junk persists indefinitely. Three PRs are in exactly that state today (openclaw/openclaw#110714, #122591 and #1182 all correctly re-ran and skipped, leaving their old blocks in place).
live-proof-attach --detachretracts one. It removes only the recording block and keeps the plan (still legitimate review output), is a clean no-op when no block exists, works after the head has moved — a retraction must not require a matching manifest or SHA — and reuses the attach path's attempt-scoped hydrated baseline, bounded canonical-conflict retry, and comment-sync-after-publication so the record and the public comment lose the block together.--dry-runpreviews the mutations.Validation
pnpm buildclean; live-proof suite 39/39; full unit suite 2,332 passed / 0 failed (parallel with review, exit 0).