feat(live-proof): retract published recordings from workflow dispatch - #1201
Merged
Conversation
Detach existed only as a CLI, so stale recordings on public PRs could not be retracted without the records hydration and target write token that only a workflow job holds. live-proof.yml gains mode=attach|retract; retraction skips the untrusted execute job entirely and reuses the trusted attach setup, requiring no artifact, manifest, or matching head SHA.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat(live-proof): retract published recordings from workflow dispatch This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--detach(#1200) exists only as a CLI, but retraction needs the records-Worker hydration and target write token that only a workflow job holds — so the stale recordings on public PRs could not actually be removed. Three PRs are in that state today (openclaw/openclaw#110714, openclaw/openclaw#122591, #1182: all re-ran correctly under #1199 and skipped, so nothing overwrote their old blocks).live-proof.ymlgains amodeinput (attachdefault,retract). Retraction skips the untrusted execute job entirely and reuses the existing trusted attach setup — no newsetup-statesite, so the audited inventory stays at 22 — and requires no artifact, manifest, or matching head SHA, since a retraction must work after the head has moved.Validation
pnpm buildclean; live-proof suite 39/39; state-writer audit 8/8 (setup-state count unchanged at 22); full unit suite 2,332 passed / 0 failed.