fix(live-proof): install the target toolchain and assert satisfiable values - #1206
Merged
Conversation
…values openclaw/clawhub#3457 failed before its first step with `bun: not found` because the review runner ships pnpm only, and both first merged runs asserted values their demonstrations could never produce — an invented search term and a test-suite pass count. The target's package manager is now installed on demand once the verification gates pass, with installer failure published as a failed verification rather than failing the review, and the prompt requires assertions to name values the run will certainly render or print.
Contributor
|
🦞👀 Pull request received. I will update this pull request when review starts. |
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(live-proof): install the target toolchain and assert satisfiable values This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two findings from the first real runs of the merged one-job architecture.
Toolchain. openclaw/clawhub#3457 failed before its first step with
sh -lc bun install --ignore-scripts failed: sh: 1: bun: not found— the review runner ships pnpm, and ClawHub is a bun repository. The target's package manager is now installed on demand from the repository profile'spackage_manager, only after the verification gates pass so ordinary reviews stay lean, and an installer failure publishes a failed verification result rather than failing the review.Assertion quality. Both first merged runs asserted values their demonstrations could never satisfy: #1182 filled the Bay finder with an invented
97722and assertedFound, and clawhub asserted the literal52 passedfrom a test suite. The prompt now requires:Worth noting what #1182 already proved despite that failure:
press /andwait_for #finder-input:focusboth PASSED, verifying live that the keyboard shortcut the PR adds actually works.Validation
pnpm buildclean; live-proof 52/52; prompt-policy 39/39; full unit suite 2,347 passed / 0 failed.curl -fsSL https://bun.sh/install | bash.