Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specific joint selection to reset_joints_by_offset #369

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mitchell-Torok
Copy link

@Mitchell-Torok Mitchell-Torok commented Apr 20, 2024

Description

The reset_joints_by_offset function resets all the robot joint variables regardless of the ones passed through with asset_cfg.

This change only fixes reset_joints_by_offset however It may also apply to reset_joints_by_scale and others, I just have not tested these other functions.

Fixes #368

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

Checklist

  • I have run the pre-commit checks with ./orbit.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the tests with ./orbit.sh --test and they pass
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] mdp.reset_joints_by_offset resets entire robot instead of the specified joint
1 participant