Skip to content

Commit

Permalink
Changes 'unalias' to 'unset' inside setup_conda_env in orbit.sh (#378)
Browse files Browse the repository at this point in the history
The line `'unalias ORBIT_PATH &>/dev/null'` inside `setup_conda_env()`
prevents `orbit.sh --conda` to successfully exit. The "`unset`" command
rather than "`unalias`" should be used for environment variables (e.g.,
`ORBIT_PATH`). This is a problem, e.g., when a custom dockerfile is used
to directly install conda during the image build process: the image
build process is interrupted.

Fixes #377

- Bug fix (non-breaking change which fixes an issue)

Before:

https://github.com/NVIDIA-Omniverse/orbit/blob/a642b8e32cf07efa11a583e8db3680d971922e1e/orbit.sh#L148
After:
`'unset ORBIT_PATH' \`

- [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with
`./orbit.sh --format`
- [ ] I have made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have run all the tests with `./orbit.sh --test` and they pass
- [ ] I have updated the changelog and the corresponding version in the
extension's `config/extension.toml` file
- [x] I have added my name to the `CONTRIBUTORS.md` or my name already
exists there
  • Loading branch information
ozhanozen authored and Mayankm96 committed Apr 22, 2024
1 parent a642b8e commit 7cc56c3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Guidelines for modifications:
* Jia Lin Yuan
* Jingzhou Liu
* Kourosh Darvish
* Özhan Özen
* Qinxi Yu
* René Zurbrügg
* Ritvik Singh
Expand Down
2 changes: 1 addition & 1 deletion orbit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ setup_conda_env() {
printf '%s\n' '#!/usr/bin/env bash' '' \
'# for orbit' \
'unalias orbit &>/dev/null' \
'unalias ORBIT_PATH &>/dev/null' \
'unset ORBIT_PATH' \
'' \
'# for isaac-sim' \
'unset CARB_APP_PATH' \
Expand Down

0 comments on commit 7cc56c3

Please sign in to comment.