Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Move is.hail.check to test code #14801

Open
wants to merge 1 commit into
base: ehigham/ctx-coercer-cache
Choose a base branch
from
Open

[query] Move is.hail.check to test code #14801

wants to merge 1 commit into from
+1,157 −2,005

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Jan 24, 2025 •
edited
Loading

This change re-adopts scalacheck and extracts all Gen and Arbitrary logic into is.hail.scalacheck.
This change has low security impact as it refactors code only used by tests into the test package.

This was referenced Jan 24, 2025
Closed
Open
Merged
Merged
Open
Merged
Merged
Open
Open
Open
Closed
Open
Open
@ehigham Graphite App
Copy link
Member Author

ehigham commented Jan 24, 2025 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ehigham ehigham mentioned this pull request Jan 24, 2025
Merged
@ehigham ehigham marked this pull request as ready for review January 24, 2025 20:36
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from df36f36 to 51edeb7 Compare January 24, 2025 20:54
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from b6a31f7 to fc08ea1 Compare January 24, 2025 20:54
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 51edeb7 to 07eaf29 Compare January 27, 2025 23:15
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from fc08ea1 to 97dd229 Compare January 27, 2025 23:15
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch 2 times, most recently from 006475e to 8330580 Compare January 29, 2025 20:22
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 97dd229 to db88046 Compare January 29, 2025 20:22
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 8330580 to d7b182d Compare January 29, 2025 20:39
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from db88046 to 1ff37b2 Compare January 29, 2025 20:40
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from d7b182d to d1cf72f Compare January 29, 2025 21:40
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 1ff37b2 to 174743e Compare January 29, 2025 21:41
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from d1cf72f to cf11bbe Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 174743e to 6399b8e Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from cf11bbe to aa8477e Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 6399b8e to 467af85 Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from aa8477e to 490b5a6 Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 467af85 to b7240de Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 490b5a6 to fcdedec Compare January 31, 2025 21:21
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from b7240de to c85bc8f Compare January 31, 2025 21:22
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from fcdedec to b0c0615 Compare February 3, 2025 17:20
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from c85bc8f to 3f69dce Compare February 3, 2025 17:20
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from b0c0615 to 1fbfbbd Compare February 3, 2025 18:01
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 3f69dce to 5c49087 Compare February 3, 2025 18:01
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 1fbfbbd to d7d8ab1 Compare February 3, 2025 20:51
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch 2 times, most recently from c9490df to f3851ca Compare February 3, 2025 23:07
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from d7d8ab1 to 8f40db1 Compare February 4, 2025 22:44
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from f3851ca to b632b66 Compare February 4, 2025 22:44
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 8f40db1 to c2882b7 Compare February 6, 2025 18:44
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from b632b66 to 0b2a31a Compare February 6, 2025 18:44
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 0b2a31a to e67036c Compare February 20, 2025 16:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from e226050 to 4566500 Compare February 20, 2025 17:28
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from e67036c to 314321a Compare February 20, 2025 17:28
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 4566500 to e218589 Compare February 27, 2025 22:17
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 314321a to 3dfd959 Compare February 27, 2025 22:17
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from e218589 to 0c246e1 Compare March 3, 2025 17:55
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 3dfd959 to 13d5439 Compare March 3, 2025 17:55
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch 2 times, most recently from 6ea4e2f to 5dfe699 Compare March 17, 2025 22:48
@ehigham ehigham mentioned this pull request Mar 18, 2025
Open
@ehigham ehigham force-pushed the ehigham/move-gen-into-tests branch from 5dfe699 to fa8b624 Compare March 19, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehigham