Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Remove persistedIr from Backend interface #14692

Merged
merged 1 commit into from
Feb 28, 2025
Merged

[query] Remove persistedIr from Backend interface #14692

merged 1 commit into from
Feb 28, 2025

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 18, 2024 •
edited
Loading

This change factors the choice of ir caching strategy out of the Backend by exposing the persisted IR cache via the ExecuteContext. As a consequence, the IRParserEnvironment just becomes an ExecuteContext.

This change has low security impact.

@ehigham ehigham mentioned this pull request Sep 18, 2024
Merged
@ehigham ehigham marked this pull request as ready for review September 18, 2024 16:46
This was referenced Sep 18, 2024
Merged
Merged
@ehigham Graphite App
Copy link
Member Author

ehigham commented Sep 18, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 18, 2024
Merged
Merged
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch 2 times, most recently from ea72e96 to d86b932 Compare September 18, 2024 17:15
@ehigham ehigham mentioned this pull request Sep 19, 2024
Closed
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from a47ef8b to 1530549 Compare September 19, 2024 20:53
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 40cfdd1 to 8ac34e8 Compare September 19, 2024 20:53
This was referenced Sep 20, 2024
Open
Open
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 1530549 to d3a662f Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 8ac34e8 to 956e751 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d3a662f to f00e349 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 956e751 to c07ff10 Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from f00e349 to 532bd55 Compare October 8, 2024 19:18
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from c07ff10 to e7782e2 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 532bd55 to 324bae5 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from e7782e2 to 7969e05 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 324bae5 to 7e738cc Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 7969e05 to 1142a0d Compare October 16, 2024 20:02
@ehigham ehigham mentioned this pull request Oct 16, 2024
Open
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 7e738cc to 8fd036a Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 1142a0d to cf4fa39 Compare October 16, 2024 21:30
@ehigham ehigham mentioned this pull request Oct 17, 2024
Closed
1 task
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 8fd036a to a3aae4a Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from cf4fa39 to 12b4b5a Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from c86812f to 23be511 Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from f8830d3 to 0ab8b01 Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 23be511 to 5654839 Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 0ab8b01 to 9d5cf6c Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 5654839 to 2956a6b Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9d5cf6c to dde4ab0 Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 2956a6b to d970a8b Compare January 31, 2025 21:21
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from dde4ab0 to 071d613 Compare January 31, 2025 21:21
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d970a8b to 0a3e70c Compare February 3, 2025 17:20
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 071d613 to ea9666d Compare February 3, 2025 17:20
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from 0a3e70c to d0d4917 Compare February 3, 2025 18:00
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from ea9666d to 7d6b30f Compare February 3, 2025 18:00
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d0d4917 to ee399d1 Compare February 3, 2025 20:51
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 7d6b30f to bd3988a Compare February 3, 2025 20:51
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from ee399d1 to d56d118 Compare February 4, 2025 22:44
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from bd3988a to 9397c47 Compare February 4, 2025 22:44
@ehigham ehigham force-pushed the ehigham/ctx-code-cache branch from d56d118 to be3e8f8 Compare February 6, 2025 18:44
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9397c47 to aaf021a Compare February 6, 2025 18:44
Base automatically changed from ehigham/ctx-code-cache to main February 19, 2025 20:44
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch 2 times, most recently from d8a765e to fe61d6d Compare February 20, 2025 17:28
chrisvittal
chrisvittal approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@chrisvittal chrisvittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems much simpler. Thanks!

@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from fe61d6d to 2c24fd9 Compare February 27, 2025 22:17
patrick-schultz
patrick-schultz approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@patrick-schultz patrick-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification, make perfect sense!

@hail-ci-robot hail-ci-robot merged commit 51ca2b1 into main Feb 28, 2025
2 checks passed
@hail-ci-robot hail-ci-robot deleted the ehigham/ctx-persisted-ir branch February 28, 2025 20:06
@ehigham ehigham mentioned this pull request Mar 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-schultz patrick-schultz patrick-schultz approved these changes

@chrisvittal chrisvittal chrisvittal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehigham @patrick-schultz @chrisvittal @hail-ci-robot