-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[query] Move LoweredTableReaderCoercer into ExecuteContext #14696
base: main
Are you sure you want to change the base?
Conversation
f2c39a6
to
2f3f122
Compare
16d54bd
to
82cd91b
Compare
2f3f122
to
b02c83b
Compare
82cd91b
to
63191ba
Compare
b02c83b
to
20e6520
Compare
63191ba
to
dded098
Compare
20e6520
to
e66b858
Compare
dded098
to
4f3a6e3
Compare
e66b858
to
49bdf73
Compare
4f3a6e3
to
db7595e
Compare
49bdf73
to
0ce4a09
Compare
db7595e
to
9615ece
Compare
0ce4a09
to
3a671ee
Compare
9615ece
to
1951717
Compare
3a671ee
to
ee01140
Compare
1951717
to
3f89fe2
Compare
ee01140
to
22c3b9b
Compare
3f89fe2
to
1d6e424
Compare
0ab8b01
to
9d5cf6c
Compare
cf11bbe
to
aa8477e
Compare
9d5cf6c
to
dde4ab0
Compare
aa8477e
to
490b5a6
Compare
dde4ab0
to
071d613
Compare
490b5a6
to
fcdedec
Compare
071d613
to
ea9666d
Compare
fcdedec
to
b0c0615
Compare
ea9666d
to
7d6b30f
Compare
b0c0615
to
1fbfbbd
Compare
7d6b30f
to
bd3988a
Compare
1fbfbbd
to
d7d8ab1
Compare
bd3988a
to
9397c47
Compare
d7d8ab1
to
8f40db1
Compare
9397c47
to
aaf021a
Compare
8f40db1
to
c2882b7
Compare
aaf021a
to
d8a765e
Compare
c2882b7
to
e226050
Compare
d8a765e
to
fe61d6d
Compare
e226050
to
4566500
Compare
4566500
to
e218589
Compare
fe61d6d
to
2c24fd9
Compare
e218589
to
0c246e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change. While I was looking into what LoweredTableReaderCoercer
does, I noticed it's only used in the VCF and Plink readers. That makes me think we could get rid of LoweredTableReaderCoercer
and GenericTableValue
completely if we refactored those readers to create TableStage
s directly, probably using registered functions to do the actual parsing logic. But thats just something to think about for the future.
0c246e1
to
52480a9
Compare
Refactored table reader coercion and caching mechanism.
What changed?
shouldCacheQueryInfo
method fromBackend
classCoercerCache
inExecuteContext
LoweredTableReader.makeCoercer
to return a function instead of a classGenericTableValue
andLoweredTableReader
Why make this change?
This change aims to optimize table reader coercion by:
ExecuteContext