Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Move LoweredTableReaderCoercer into ExecuteContext #14696

Open
wants to merge 1 commit into
base: ehigham/ctx-persisted-ir
Choose a base branch
from
Open

[query] Move LoweredTableReaderCoercer into ExecuteContext #14696

wants to merge 1 commit into from
+358 −375

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Sep 20, 2024 •
edited
Loading

Refactored table reader coercion and caching mechanism.

What changed?

  • Removed shouldCacheQueryInfo method from Backend class
  • Introduced CoercerCache in ExecuteContext
  • Refactored LoweredTableReader.makeCoercer to return a function instead of a class
  • Removed local caching in GenericTableValue and LoweredTableReader
  • Added NoCaching utility

Why make this change?

This change aims to optimize table reader coercion by:

  • Centralizing caching logic in ExecuteContext
  • Allowing more flexible caching strategies across different backend implementations

@ehigham ehigham marked this pull request as ready for review September 20, 2024 00:03
This was referenced Sep 20, 2024
Merged
Merged
Merged
Open
Open
Open
@ehigham Graphite App
Copy link
Member Author

ehigham commented Sep 20, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 20, 2024
Closed
Open
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from f2c39a6 to 2f3f122 Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 16d54bd to 82cd91b Compare October 1, 2024 19:45
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 2f3f122 to b02c83b Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 82cd91b to 63191ba Compare October 1, 2024 20:03
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from b02c83b to 20e6520 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 63191ba to dded098 Compare October 8, 2024 19:19
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 20e6520 to e66b858 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from dded098 to 4f3a6e3 Compare October 8, 2024 20:30
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from e66b858 to 49bdf73 Compare October 16, 2024 20:02
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 4f3a6e3 to db7595e Compare October 16, 2024 20:02
@ehigham ehigham mentioned this pull request Oct 16, 2024
Open
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 49bdf73 to 0ce4a09 Compare October 16, 2024 21:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from db7595e to 9615ece Compare October 16, 2024 21:30
@ehigham ehigham mentioned this pull request Oct 17, 2024
Closed
1 task
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 0ce4a09 to 3a671ee Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 9615ece to 1951717 Compare October 17, 2024 15:00
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 3a671ee to ee01140 Compare October 21, 2024 15:24
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 1951717 to 3f89fe2 Compare October 21, 2024 15:25
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from ee01140 to 22c3b9b Compare October 21, 2024 18:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 3f89fe2 to 1d6e424 Compare October 21, 2024 18:50
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from 220a71a to bbbea4f Compare January 22, 2025 15:50
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 9922a19 to cf90a1c Compare January 22, 2025 15:51
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from bbbea4f to db27b14 Compare January 22, 2025 16:46
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from cf90a1c to b9c311f Compare January 22, 2025 16:46
@ehigham ehigham force-pushed the ehigham/http-like-rpc branch from db27b14 to 3eae5a8 Compare January 22, 2025 17:30
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch 2 times, most recently from 4c724ba to df36f36 Compare January 22, 2025 21:13
@ehigham ehigham changed the base branch from ehigham/http-like-rpc to ehigham/ctx-persisted-ir January 22, 2025 21:13
@ehigham ehigham mentioned this pull request Jan 24, 2025
Open
1 task
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 234a058 to 804d4fa Compare January 24, 2025 20:54
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from df36f36 to 51edeb7 Compare January 24, 2025 20:54
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 804d4fa to dd7471c Compare January 27, 2025 23:15
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 51edeb7 to 07eaf29 Compare January 27, 2025 23:15
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from dd7471c to 0b07e0a Compare January 29, 2025 19:00
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 07eaf29 to 006475e Compare January 29, 2025 19:00
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 0b07e0a to 4b12f9a Compare January 29, 2025 20:21
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 006475e to 8330580 Compare January 29, 2025 20:22
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 4b12f9a to f455097 Compare January 29, 2025 20:39
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 8330580 to d7b182d Compare January 29, 2025 20:39
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from f455097 to f8830d3 Compare January 29, 2025 21:40
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from d7b182d to d1cf72f Compare January 29, 2025 21:40
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from f8830d3 to 0ab8b01 Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from d1cf72f to cf11bbe Compare January 30, 2025 19:52
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 0ab8b01 to 9d5cf6c Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from cf11bbe to aa8477e Compare January 31, 2025 19:12
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from 9d5cf6c to dde4ab0 Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from aa8477e to 490b5a6 Compare January 31, 2025 19:27
@ehigham ehigham force-pushed the ehigham/ctx-persisted-ir branch from dde4ab0 to 071d613 Compare January 31, 2025 21:21
@ehigham ehigham force-pushed the ehigham/ctx-coercer-cache branch from 490b5a6 to fcdedec Compare January 31, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ehigham