Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Benchmark configurations #14762

Open
wants to merge 1 commit into
base: ehigham/benchmark-in-batch-variability
Choose a base branch
from

Conversation

ehigham
Copy link
Member

@ehigham ehigham commented Dec 5, 2024

Change Description

Added benchmark parameters to all benchmark tests in the Hail codebase. Each test now specifies:

  • Minimum detectable slowdown (mds)
  • Number of instances (ie number of batch jobs)
  • Number of iterations (how many timed trials of the benchmark per instance)
  • Number of burn-in iterations (number of untimed trials run before timing)

These parameters allow for more precise and controlled benchmark measurements by explicitly defining the statistical requirements and execution parameters for each test.

Security Assessment

This change has no security impact

Impact Description

Low-level test configuration changes only - modifies benchmark test parameters without changing any functional code or test logic.

@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from 54cd48a to 93e81d9 Compare December 5, 2024 21:16
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from fa2e947 to 8b98a0c Compare December 5, 2024 21:16
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from 93e81d9 to 2344aed Compare December 5, 2024 21:19
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8b98a0c to 692247b Compare December 5, 2024 21:20
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from 2344aed to e8cb1fb Compare December 5, 2024 21:42
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 692247b to e638c1c Compare December 5, 2024 21:42
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from e8cb1fb to c4a8c24 Compare December 5, 2024 21:52
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from e638c1c to 8bad700 Compare December 5, 2024 21:53
@ehigham ehigham force-pushed the ehigham/benchmark-suite-improvements branch from c4a8c24 to 687437c Compare December 5, 2024 22:00
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8bad700 to 69cfc52 Compare December 5, 2024 22:00
@ehigham ehigham changed the base branch from ehigham/benchmark-suite-improvements to ehigham/benchmark-in-batch-variability December 5, 2024 22:01
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 2c72cb5 to 30d0a86 Compare December 5, 2024 22:06
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 69cfc52 to f5b2196 Compare December 5, 2024 22:06
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 30d0a86 to e32bc09 Compare December 5, 2024 22:12
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from f5b2196 to 0d886d5 Compare December 5, 2024 22:13
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from e32bc09 to 97a40fa Compare December 6, 2024 23:13
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 0d886d5 to 432a727 Compare December 6, 2024 23:13
@ehigham ehigham marked this pull request as ready for review December 6, 2024 23:14
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 97a40fa to 1118f03 Compare December 12, 2024 21:52
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 432a727 to b1f3066 Compare December 12, 2024 21:52
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 1118f03 to f79f8c1 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from b1f3066 to 2299a17 Compare December 12, 2024 22:01
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from f79f8c1 to af0036a Compare December 12, 2024 22:03
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 2299a17 to a128b0f Compare December 12, 2024 22:03
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from af0036a to e61f806 Compare December 16, 2024 18:50
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from a128b0f to db53a7e Compare December 16, 2024 18:50
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 0f6510c to 54ea602 Compare January 24, 2025 20:35
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 6c02fa7 to 4a43a71 Compare January 24, 2025 20:55
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 54ea602 to 78d53e2 Compare January 24, 2025 20:55
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 4a43a71 to 48b9a81 Compare January 27, 2025 23:16
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 78d53e2 to a349606 Compare January 27, 2025 23:16
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 48b9a81 to 0bff74d Compare January 29, 2025 20:26
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from a349606 to f46603c Compare January 29, 2025 20:27
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 0bff74d to 10ca001 Compare January 29, 2025 20:40
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from f46603c to b606d8c Compare January 29, 2025 20:41
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 10ca001 to 8cbac01 Compare January 29, 2025 21:18
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from b606d8c to 5162e5f Compare January 29, 2025 21:18
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 8cbac01 to c3ab3a7 Compare January 29, 2025 21:41
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 5162e5f to 99d6492 Compare January 29, 2025 21:41
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from c3ab3a7 to b66167b Compare January 29, 2025 22:24
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 99d6492 to a144ff8 Compare January 29, 2025 22:24
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from b66167b to 6f361f4 Compare January 29, 2025 22:30
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from a144ff8 to 8a0d081 Compare January 29, 2025 22:30
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 6f361f4 to 545ffdf Compare January 29, 2025 22:41
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8a0d081 to 8d17a31 Compare January 29, 2025 22:41
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 545ffdf to 4c00b78 Compare January 29, 2025 22:54
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 8d17a31 to a86cb14 Compare January 29, 2025 22:54
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 4c00b78 to f8faba5 Compare January 30, 2025 19:53
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from a86cb14 to b16d71b Compare January 30, 2025 19:53
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from f8faba5 to 78afb48 Compare January 31, 2025 19:13
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from b16d71b to 223a577 Compare January 31, 2025 19:13
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 78afb48 to 2214856 Compare January 31, 2025 19:28
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 223a577 to 2541f2e Compare January 31, 2025 19:28
@ehigham ehigham force-pushed the ehigham/benchmark-in-batch-variability branch from 2214856 to 573cf80 Compare January 31, 2025 21:22
@ehigham ehigham force-pushed the ehigham/benchmark-configurations branch from 2541f2e to d8c14b9 Compare January 31, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant