[qob] cancel stage if any partitions fail. #14747
Open
+52
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1 task
grohli
force-pushed
the
qob-fast-cancel
branch
from
5c9e4ae to
a0b5577
Compare
chrisvittal
approved these changes
Oct 29, 2024
patrick-schultz
requested changes
Oct 29, 2024
ehigham
reviewed
Oct 30, 2024
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
4cf050e to
01aedac
Compare
grohli
force-pushed
the
qob-fast-cancel
branch
from
a0b5577 to
9f6d876
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
01aedac to
6e36a7a
Compare
grohli
force-pushed
the
qob-fast-cancel
branch
from
9f6d876 to
daa4a2e
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
6e36a7a to
e121222
Compare
This was referenced Dec 5, 2024
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
0a14104 to
4b932f1
Compare
ehigham
force-pushed
the
ehigham/cloud-credentials
branch
from
4b932f1 to
64042bc
Compare
grohli
force-pushed
the
qob-fast-cancel
branch
from
54aae49 to
aa8a2e8
Compare
Just revisiting this comment--does the question you had about the test still apply? Or is it several commits old now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Fixes #14597
cancel_after_n_failures = 1; cancels whole job group if one partition fails.
Security Assessment
Impact Description
Unit tests and no interaction on anything secure.
(Reviewers: please confirm the security impact before approving)