Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Car Port for Genesis GV70 2022-23 (HDA2) #1133

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Aug 20, 2024

Checklist

  • added entry to CAR in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with openpilot:
    • f1b6af6fdf6c0a78: f1b6af6fdf6c0a78/00000004--5a6db3a9bd
    • 1159e79fa5ec2cb0: 1159e79fa5ec2cb0/0000000a--0dd85e8bd2
  • route with stock system: afe09b9f5d3f3548/00000005--fe8cd35e57
  • car harness used (if comma doesn't sell it, put N/A): N/A (See below)

Thanks to the community 2022 Genesis GV70 3.5T owners taylababygirl (Discord) and animatronichobbes.

Offline Validation

  • pytest opendbc
  • pytest selfdrive/car/tests
  • selfdrive/test/process_replay/test_processes.py

Superseded commaai/openpilot#31704

Copy link
Contributor

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

@sunnyhaibin sunnyhaibin changed the title HKG: Car Port for Genesis GV70 2022 (3.5T, HDA2) HKG: Car Port for Genesis GV70 2022 (HDA2) Sep 25, 2024
@sunnyhaibin sunnyhaibin changed the title HKG: Car Port for Genesis GV70 2022 (HDA2) HKG: Car Port for Genesis GV70 2022-23 (HDA2) Sep 26, 2024
@sunnyhaibin
Copy link
Contributor Author

Genesis GV70 2022, 2.5T, HDA2: 1159e79fa5ec2cb0/00000001--b77cb31c46

Copy link
Collaborator

@jyoung8607 jyoung8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per our Discord discussion, this one needs a test route. The one in the PR comments is no longer available, and when we find one, you'll need to add it to routes.py. Switched to draft until that's available.

When you get the test route, it will save some time if you can sanity-check the steerRatio and lateral accel performance and so forth before exiting draft.

After that, the PR will be good from your side, but we'll have to hold the new GV70 model-variants in dashcam mode until their harness becomes available. That will require a bit of CarDocs infrastructure support, but I'll take care of that.

@sunnyhaibin sunnyhaibin marked this pull request as ready for review September 28, 2024 01:49
@sunnyhaibin
Copy link
Contributor Author

@jyoung8607 Test route has rlogs uploaded and preserved.

Copy link
Contributor

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Nov 17, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

@github-actions github-actions bot closed this Nov 23, 2024
@adeebshihadeh adeebshihadeh reopened this Nov 23, 2024
@github-actions github-actions bot removed the stale label Nov 25, 2024
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity.

@github-actions github-actions bot added the stale label Dec 4, 2024
Copy link
Contributor

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
car related to opendbc/car/ hyundai
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants