-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HKG: Car Port for Genesis GV70 2022-23 (HDA2) #1133
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
|
Genesis GV70 2022, 2.5T, HDA2: |
…hda2 # Conflicts: # opendbc/car/hyundai/interface.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per our Discord discussion, this one needs a test route. The one in the PR comments is no longer available, and when we find one, you'll need to add it to routes.py. Switched to draft until that's available.
When you get the test route, it will save some time if you can sanity-check the steerRatio and lateral accel performance and so forth before exiting draft.
After that, the PR will be good from your side, but we'll have to hold the new GV70 model-variants in dashcam mode until their harness becomes available. That will require a bit of CarDocs infrastructure support, but I'll take care of that.
@jyoung8607 Test route has rlogs uploaded and preserved. |
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes. |
Checklist
selfdrive/car/docs.py
to generate new docsf1b6af6fdf6c0a78
:f1b6af6fdf6c0a78/00000004--5a6db3a9bd
1159e79fa5ec2cb0
:1159e79fa5ec2cb0/0000000a--0dd85e8bd2
afe09b9f5d3f3548/00000005--fe8cd35e57
N/A
(See below)Thanks to the community 2022 Genesis GV70 3.5T owners taylababygirl (Discord) and animatronichobbes.
Offline Validation
pytest opendbc
pytest selfdrive/car/tests
selfdrive/test/process_replay/test_processes.py
Superseded commaai/openpilot#31704