Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: Car Port for Genesis GV70 2022-23 (HDA2) #1133

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

HKG: Car Port for Genesis GV70 2022-23 (HDA2) #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1d0d5d2
HKG: Car Port for Genesis GV70 2022 (3.5T, HDA2)
sunnyhaibin Aug 20, 2024
c8497e2
Merge remote-tracking branch 'commaai/opendbc/master' into gv70-2022-…
sunnyhaibin Sep 25, 2024
f9058a3
Apply #1284
sunnyhaibin Sep 25, 2024
a99debe
Apply #1285
sunnyhaibin Sep 25, 2024
8b6ee97
update car specs
sunnyhaibin Sep 26, 2024
54f0a83
update name and harness
sunnyhaibin Sep 26, 2024
0f5fc7e
Merge remote-tracking branch 'commaai/opendbc/master' into gv70-2022-…
sunnyhaibin Sep 27, 2024
cecf266
Merge remote-tracking branch 'commaai/opendbc/master' into gv70-2022-…
sunnyhaibin Sep 27, 2024
53681cc
Update comment
sunnyhaibin Sep 27, 2024
097f8c5
add test route
sunnyhaibin Sep 28, 2024
d15118e
Merge remote-tracking branch 'commaai/opendbc/master' into gv70-2022-…
sunnyhaibin Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions opendbc/car/docs_definitions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ class CarHarness(EnumBase):
hyundai_p = BaseCarHarness("Hyundai P connector")
hyundai_q = BaseCarHarness("Hyundai Q connector")
hyundai_r = BaseCarHarness("Hyundai R connector")
hyundai_s = BaseCarHarness("Hyundai S connector")
custom = BaseCarHarness("Developer connector")
obd_ii = BaseCarHarness("OBD-II connector", parts=[Cable.long_obdc_cable, Cable.long_obdc_cable], has_connector=False)
gm = BaseCarHarness("GM connector", parts=[Accessory.harness_box])
Expand Down
2 changes: 2 additions & 0 deletions opendbc/car/hyundai/fingerprints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,11 +1053,13 @@
b'\xf1\x00JK1 MFC AT USA LHD 1.00 1.01 99211-AR200 220125',
b'\xf1\x00JK1 MFC AT USA LHD 1.00 1.01 99211-AR300 220125',
b'\xf1\x00JK1 MFC AT USA LHD 1.00 1.04 99211-AR000 210204',
b'\xf1\x00JK1 MFC AT USA LHD 1.00 1.04 99211-AR100 210204',
],
(Ecu.fwdRadar, 0x7d0, None): [
b'\xf1\x00JK1_ SCC FHCUP 1.00 1.00 99110-AR200 ',
b'\xf1\x00JK1_ SCC FHCUP 1.00 1.00 99110-AR300 ',
b'\xf1\x00JK1_ SCC FHCUP 1.00 1.02 99110-AR000 ',
b'\xf1\x00JK1_ SCC ----- 1.00 1.02 99110-AR100 ',
],
},
CAR.GENESIS_GV70_ELECTRIFIED_1ST_GEN: {
Expand Down
8 changes: 5 additions & 3 deletions opendbc/car/hyundai/values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,9 +523,11 @@ class CAR(Platforms):
)
GENESIS_GV70_1ST_GEN = HyundaiCanFDPlatformConfig(
[
# TODO: Hyundai P is likely the correct harness for HDA II for 2.5T (unsupported due to missing ADAS ECU, is that the radar?)
HyundaiCarDocs("Genesis GV70 (2.5T Trim, without HDA II) 2022-23", "All", car_parts=CarParts.common([CarHarness.hyundai_l])),
HyundaiCarDocs("Genesis GV70 (3.5T Trim, without HDA II) 2022-23", "All", car_parts=CarParts.common([CarHarness.hyundai_m])),
# TODO: HDA II variants are missing ADAS ECU, possibly the radar ECU is acting as one
HyundaiCarDocs("Genesis GV70 (2.5T Trim, without HDA II) 2022-23", "Highway Driving Assist", car_parts=CarParts.common([CarHarness.hyundai_l])),
HyundaiCarDocs("Genesis GV70 (2.5T Trim, with HDA II) 2022-23", "Highway Driving Assist II", car_parts=CarParts.common([CarHarness.hyundai_p])),
HyundaiCarDocs("Genesis GV70 (3.5T Trim, without HDA II) 2022-23", "Highway Driving Assist", car_parts=CarParts.common([CarHarness.hyundai_m])),
HyundaiCarDocs("Genesis GV70 (3.5T Trim, with HDA II) 2022-23", "Highway Driving Assist II", car_parts=CarParts.common([CarHarness.hyundai_s])),
],
CarSpecs(mass=1950, wheelbase=2.87, steerRatio=14.6),
flags=HyundaiFlags.RADAR_SCC,
Expand Down
1 change: 1 addition & 0 deletions opendbc/car/tests/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ class CarTestRoute(NamedTuple):
CarTestRoute("b5d6dc830ad63071|2022-12-12--21-28-25", HYUNDAI.GENESIS_GV60_EV_1ST_GEN, segment=12),
CarTestRoute("70c5bec28ec8e345|2020-08-08--12-22-23", HYUNDAI.GENESIS_G70),
CarTestRoute("ca4de5b12321bd98|2022-10-18--21-15-59", HYUNDAI.GENESIS_GV70_1ST_GEN),
CarTestRoute("1159e79fa5ec2cb0/0000000a--0dd85e8bd2", HYUNDAI.GENESIS_GV70_1ST_GEN), # HDA2
CarTestRoute("afe09b9f5d3f3548/00000011--15fefe1c50", HYUNDAI.GENESIS_GV70_ELECTRIFIED_1ST_GEN),
CarTestRoute("afe09b9f5d3f3548/0000001b--a1129a4a15", HYUNDAI.GENESIS_GV70_ELECTRIFIED_1ST_GEN), # openpilot longitudinal enabled
CarTestRoute("6b301bf83f10aa90|2020-11-22--16-45-07", HYUNDAI.GENESIS_G80),
Expand Down
Loading