Hyundai CAN-FD: Add CAN fingerprint fallback checks for HDA2 detection #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Sep 25, 2024
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Sep 25, 2024
jyoung8607
reviewed
Sep 26, 2024
sshane
reviewed
Sep 26, 2024
opendbc/car/hyundai/interface.py
Outdated
Comment on lines
34
to
35
| # Some HDA2 cars do not respond ADAS Driving ECU if the known HDA2 steering messages are present. | ||
| # The hda2 flag to initialize CanBus is not critical here since we only care about CAM bus steering messages. |
There was a problem hiding this comment.
I don't think we've ever verified what is sending LFA here btw. The ADAS could actually exist but behind a new gateway (a FW scan on OBD port should show it), or it could actually not exist and radar might take over this function.
jyoung8607
requested changes
Sep 26, 2024
jyoung8607
reviewed
Sep 27, 2024
Co-authored-by: Jason Young <[email protected]>
sunnyhaibin
force-pushed
the
hyundai-canfd-hda2-alt-check
branch
from
68c6ae7 to
f0a4a50
Compare
|
Offline Validation
|
|
Looks good! PR review bot fail looks to be a Docker outage. |
jyoung8607
added a commit
that referenced
this pull request
Sep 27, 2024
* HKG: Car Port for Genesis G80 2024 (2.5T, HDA2) * Apply #1284 * Apply #1285 * add test route * Update opendbc/car/hyundai/values.py Co-authored-by: Jason Young <[email protected]> --------- Co-authored-by: Jason Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add fallback detection for HDA2 cars using CAM bus fingerprinting when ADAS Driving ECU response is absent.
Prerequisite of