Hyundai: Disable longitudinal for HDA2 without ADAS Driving ECU #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunnyhaibin
changed the title
|
Depends on, and will need a rebase after #1294. |
|
Offline validations passed. |
|
This PR has had no activity for 9 days. It will be automatically closed in 2 days if there is no activity. |
|
HDA2 kinda means "has ADAS ECU", or at least that's what I meant at the time. It's probably time we rethought some of these names and classes. |
Comment on lines
+29
to
+33
| hda2_longitudinal = hda2 and Ecu.adas in [fw.ecu for fw in car_fw] and \ | ||
| candidate not in CANFD_UNSUPPORTED_LONGITUDINAL_CAR | ||
|
|
||
| ret.experimentalLongitudinalAvailable = hda2_longitudinal or \ | ||
| candidate not in (CANFD_UNSUPPORTED_LONGITUDINAL_CAR | CANFD_RADAR_SCC_CAR) |
There was a problem hiding this comment.
I don't see how this works? It's supposed to remove support for some cars, but this adds an or to the existing condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some HDA2 cars, the ECU that broadcasts SCC messages is still undetermined (historically should be the ADAS Driving ECU), therefore there is no known method to enable longitudinal control on these yet. Disable longitudinal control for the time being for applicable cars.
Offline Validation
pytest opendbcpytest selfdrive/car/testsselfdrive/test/process_replay/test_processes.pyAffects