Hyundai CAN-FD: Universal gear checks #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Sep 25, 2024
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Sep 25, 2024
…nfd-universal-gear # Conflicts: # opendbc/car/hyundai/interface.py
|
Offline Validation
|
|
This does check out enough to merge, but as a future TODO, there's further simplification possible. According to commaCarSegments, there are no CAN-FD cars that truly depend on 0x130 GEAR_SHIFTER. Every car that has it, has one of the other messages too. |
jyoung8607
added a commit
that referenced
this pull request
Sep 27, 2024
* HKG: Car Port for Genesis G80 2024 (2.5T, HDA2) * Apply #1284 * Apply #1285 * add test route * Update opendbc/car/hyundai/values.py Co-authored-by: Jason Young <[email protected]> --------- Co-authored-by: Jason Young <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The refactor's goal is to improve the gear checking logic to be applicable to both HDA2 and non-HDA2 Hyundai vehicles, which was previously only applied to non-HDA2 cars.
Verification
This is tested in the following active PRs:
Offline Validation
pytest opendbcpytest selfdrive/car/testsselfdrive/test/process_replay/test_processes.pySupersedes