Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: Add support for STM32F413xx #28845

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

joshanne
Copy link
Contributor

@joshanne joshanne commented Dec 12, 2024

Generated the STM32F413xx python module from datasheet (stm32f413cg) and reference manual (rm0430-stm32f413423-advanced-armbased-32bit-mcus-stmicroelectronics).

Added changes for supporting STM32F413xx to mcuconf.

@joshanne joshanne requested a review from tridge December 12, 2024 00:19
@joshanne joshanne changed the title AP_HAL_ChibiOS: Add STM32F413xx module AP_HAL_ChibiOS: Add support for STM32F413xx Dec 12, 2024
@joshanne
Copy link
Contributor Author

joshanne commented Dec 12, 2024

We are using a board with an STM32F413 - Best I can see, there have been requests (issue#8832) and attempts to add support for STM32F413xx in the past, but appears the MCU definition has never been added.

I've used the Ref Man and datasheet to pull out the CSV required to run the parser scripts.

We have a build running on the F413, seemingly without issues.

I'd be keen for a backport to periph stable if it makes sense to do so - though I've not built with this on stable yet.

@joshanne joshanne force-pushed the pr/add-support-for-STM32F413xx branch from 1b26522 to 2c3467c Compare December 13, 2024 03:09
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the drive-by's this looks correct to me and safe to go in

Generated the STM32F413xx script from reference manuals and datasheets
Added changes for supporting STM32F413 to mcuconf
fails because of iterator not returning strings and 'dict' object has no attribute 'iterkeys'. Fixed so both scripts run.
@joshanne joshanne force-pushed the pr/add-support-for-STM32F413xx branch from 2c3467c to 0ea2a3b Compare December 15, 2024 21:12
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not going to break anything unrelated.

@peterbarker peterbarker merged commit 4bc6115 into ArduPilot:master Dec 16, 2024
44 checks passed
@joshanne joshanne deleted the pr/add-support-for-STM32F413xx branch December 16, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants