-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new board: AET-H743-Basic #28371
Conversation
@villivateur there is merge commit in your PR. We do not allow merge commits so you will need to remove that. We also only allow one commit per subsystem/directory, so you will have to split out the AP_Bootloaders, and bootloader files into two different commits with appropriate names. |
230b971
to
40ecf80
Compare
40ecf80
to
be5c68d
Compare
@rishabsingh3003 The problems are fixed, please review again, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes. Also needs a README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme should provide this information and also images: https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md
Commit names should have library prefix, ie Tools: add AET-H743-Basic bootloader, etc.
4ae3c25
to
25fd0b8
Compare
I've made some changes and added the README. Please check again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think you should add bdshot to PWM3-10, feels like that might suit most users, but your call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice board!...I suggest you send a few to DEVs like PeterBarker, AndyPiper, (maybe myself) for future support facilitation
I have several other requested changes
A new design with the same pin out is on the way, some changes are made for easier use. We would definitely like to send it to all of you when it passed all tests. |
Great, let me know when you makes changes here and want a re-review |
Also, what are the Cfs7 aand Rfs7 pins? |
That's a mistake from our PCB designer. It should be CTS7 and RTS7 |
25fd0b8
to
3faa578
Compare
I've fixed most of your review. Please check. Thank you. @Hwurzburg I've test the code on my board. It works well. |
3faa578
to
856af09
Compare
When it passes your testing I will mark it for Devcall review and merge...thanks |
The test is passed on our side. |
Add a new board from AeroEggTech.
AET-H743-Basic.
The details can be found in https://www.aeroeggtech.com/en/autopilot.html