Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new board: AET-H743-Basic #28371

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

villivateur
Copy link
Contributor

Add a new board from AeroEggTech.

AET-H743-Basic.

The details can be found in https://www.aeroeggtech.com/en/autopilot.html

@rishabsingh3003
Copy link
Contributor

@villivateur there is merge commit in your PR. We do not allow merge commits so you will need to remove that. We also only allow one commit per subsystem/directory, so you will have to split out the AP_Bootloaders, and bootloader files into two different commits with appropriate names.

@villivateur
Copy link
Contributor Author

@rishabsingh3003 The problems are fixed, please review again, thank you.

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes. Also needs a README

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme should provide this information and also images: https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md

Commit names should have library prefix, ie Tools: add AET-H743-Basic bootloader, etc.

@villivateur
Copy link
Contributor Author

I've made some changes and added the README. Please check again.

Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think you should add bdshot to PWM3-10, feels like that might suit most users, but your call

Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice board!...I suggest you send a few to DEVs like PeterBarker, AndyPiper, (maybe myself) for future support facilitation
I have several other requested changes

libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/AET-H743-Basic/README.md Outdated Show resolved Hide resolved
@do1234521
Copy link

nice board!...I suggest you send a few to DEVs like PeterBarker, AndyPiper, (maybe myself) for future support facilitation
I have several other requested changes

A new design with the same pin out is on the way, some changes are made for easier use. We would definitely like to send it to all of you when it passed all tests.

@Hwurzburg
Copy link
Collaborator

Great, let me know when you makes changes here and want a re-review

@Hwurzburg
Copy link
Collaborator

Also, what are the Cfs7 aand Rfs7 pins?

@villivateur
Copy link
Contributor Author

Also, what are the Cfs7 aand Rfs7 pins?

That's a mistake from our PCB designer. It should be CTS7 and RTS7

@villivateur
Copy link
Contributor Author

villivateur commented Nov 18, 2024

I've fixed most of your review. Please check. Thank you. @Hwurzburg

I've test the code on my board. It works well.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Nov 20, 2024
@Hwurzburg
Copy link
Collaborator

When it passes your testing I will mark it for Devcall review and merge...thanks

@villivateur
Copy link
Contributor Author

When it passes your testing I will mark it for Devcall review and merge...thanks

The test is passed on our side.

@peterbarker peterbarker merged commit 3e592a9 into ArduPilot:master Nov 20, 2024
50 checks passed
@villivateur villivateur deleted the AET-H743-Basic branch November 28, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants