-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use handover detector to detect failed handover #1327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on the robot. Worked like a charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue was always it requires tuning per item it is holding. I think that downside is still there. So works like a charm for a subset of items probably. Please prove me wrong.
That subset is all objects that are not paper thin. Which includes at least all objects used in serve breakfast. I tested it with a spoon and bowl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment about the used tuning for detector works for what set of items, i.e. their dimensions
There was no tuning done in this PR. it just uses the grasp detector. Grasp detector is tuned for how accurate it can detect things. No need to add a comment here. |
There is no comment either in the challenge or the ActiveGraspDetector about which the dimensions is works on. It is only mentioned when the object is too thin/small it doesn't work. No clue about what that threshold is.\ |
Docstring of ActiveGraspDetector states anything wider than the threshold (0.075 rad on the gripper) can be detected. You can say this is not clear enough but that is not an issue for this PR
|
Merge after #1326
Fixes one of the issues in #1325