Skip to content

Removed deprecated code #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: rolling
Choose a base branch
from
Open

Removed deprecated code #217

wants to merge 4 commits into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented May 15, 2025

This code is deprecated for a while.

we should create new branches for each ROS distro. When this PR is merge we should update rosdistro too.

what do you think @mjcarroll ?

@ahcorde
Removed deprecated code
1280d42 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde requested a review from mjcarroll May 15, 2025 12:38
@ahcorde
Fixed build
0a938cb 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@mjcarroll
Copy link
Member

we should create new branches for each ROS distro.

Do you want me to tag the current HEAD as jazzy before we merge this?

@ahcorde
Copy link
Contributor Author

ahcorde commented May 16, 2025

we should create new branches for each ROS distro.

Do you want me to tag the current HEAD as jazzy before we merge this?

sounds good

@mjcarroll
Copy link
Member

https://github.com/ros/urdfdom/tree/jazzy

@ahcorde ahcorde changed the base branch from master to rolling May 20, 2025 13:59
@ahcorde
Copy link
Contributor Author

ahcorde commented May 20, 2025 •
edited
Loading

Pulls: #217
Gist: https://gist.githubusercontent.com/ahcorde/3611043e70e178eb4a300d49d07d6dde/raw/b6f88474022efdb317cef65dd2451752101b46d6/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom
TEST args: --packages-above urdfdom
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16052

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented May 20, 2025

https://github.com/ros/urdfdom/tree/jazzy

Thank you @mjcarroll, I also fixed CI.

@ahcorde
Fix compilation error
6ea0611 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde ahcorde mentioned this pull request May 20, 2025
Open
@ahcorde
Copy link
Contributor Author

ahcorde commented May 20, 2025

Related ros/urdfdom_headers#86

@ahcorde
Copy link
Contributor Author

ahcorde commented May 21, 2025 •
edited
Loading

Pulls: #217, ros/urdfdom_headers#86
Gist: https://gist.githubusercontent.com/ahcorde/3d32cb814a059725bb9aaae1acb3a9e5/raw/561e8ea7bbc734174bdf50e3f24adec55b52d2be/ros2.repos
BUILD args: --packages-above-and-dependencies urdfdom urdf urdfdom_headers
TEST args: --packages-above urdfdom urdf urdfdom_headers
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16055

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor Author

ahcorde commented May 22, 2025

@mjcarroll This other PR is related ros/urdfdom_headers#86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @mjcarroll