Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GP8 support package (OPW params, missing links, collision mesh update) #493

Merged
merged 9 commits into from
Feb 13, 2025

Conversation

cjue
Copy link
Contributor

@cjue cjue commented Apr 13, 2022

  • add opw file
  • fix link2 collision mesh
  • add flange link
  • update reference documentation
  • minor fix for velocity limits

@gavanderhoorn
Copy link
Member

@cjue: I submitted isys-vision#6 to add 132d728. Please review and merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a downsampled version of the visual mesh?

(just noticed the visual mesh is 1MB+. Not sure what happened during the review when that was initially contributed ..)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might have been from a 3D model that included a lot of internal elements which makes if harder reduce but still keep details. I should be able to generate new .dae model by converting MotoSim models that are already reduced.
@gavanderhoorn Do you want me to do it on this PR, or it's probably better to create a separate PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, no need.

It's already in the history of the repository, so adding a newer version will not reduce the total size.

Copy link
Member

@gavanderhoorn gavanderhoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as requested changes.

@gavanderhoorn gavanderhoorn changed the title Add gp8 opw Add GP8 OPW Feb 8, 2025
@gavanderhoorn gavanderhoorn changed the title Add GP8 OPW Add GP8 OPW parameters Feb 8, 2025
@cjue
Copy link
Contributor Author

cjue commented Feb 11, 2025

@cjue: I submitted isys-vision#6 to add 132d728. Please review and merge.

done

@gavanderhoorn gavanderhoorn changed the title Add GP8 OPW parameters Update GP8 support package (OPW params, missing links, collision mesh update) Feb 13, 2025
@gavanderhoorn gavanderhoorn merged commit 8ff166f into ros-industrial:kinetic-devel Feb 13, 2025
2 checks passed
@gavanderhoorn
Copy link
Member

Thanks @cjue 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants