-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GP8 support package (OPW params, missing links, collision mesh update) #493
Merged
gavanderhoorn
merged 9 commits into
ros-industrial:kinetic-devel
from
isys-vision:add_gp8_opw
Feb 13, 2025
+204
−182
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d0ba828
add opw file for the GP8
cjue 0f7ee76
fix velocity limits
cjue 795e3e7
replace link_2_l collision mesh so it doesnt restrict range of motion…
cjue 6d8099a
add updated document reference, rename test file to include model nam…
cjue 1e24ac9
urdf: include flange link, clean up whitespace
cjue 0ed2ce9
fix duplicate tool0 link
cjue 7d602e3
fix CMakeLists
cjue 4f3843a
fix small gp8 joint6 limit inaccuracy
cjue 132d728
Use radians(..) with limits from HW1486547
gavanderhoorn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# | ||
# Parameters for use with IK solvers which support OPW (Ortho-Parallel Wrist) | ||
# kinematic configurations, as described in the paper "An Analytical Solution | ||
# of the Inverse Kinematics Problem of Industrial Serial Manipulators with an | ||
# Ortho-parallel Basis and a Spherical Wrist" by Mathias Brandstötter, Arthur | ||
# Angerer, and Michael Hofbaur (Proceedings of the Austrian Robotics Workshop | ||
# 2014, 22-23 May, 2014, Linz, Austria). | ||
# | ||
# The moveit_opw_kinematics_plugin package provides such a solver. | ||
# | ||
opw_kinematics_geometric_parameters: | ||
a1: 0.040 | ||
a2: -0.040 | ||
b: 0.000 | ||
c1: 0.330 | ||
c2: 0.345 | ||
c3: 0.340 | ||
c4: 0.080 | ||
opw_kinematics_joint_offsets: [0.0, 0.0, deg(-90.0), 0.0, 0.0, deg(180.0)] | ||
opw_kinematics_joint_sign_corrections: [1, 1, -1, -1, -1, -1] |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
<!-- | ||
launch_test_gp8.xml - ROSlaunch tests | ||
Usage Instructions: | ||
1. Add the following to your CMakeLists.txt: | ||
find_package(roslaunch) | ||
roslaunch_add_file_check(test/launch_test_gp8.xml) | ||
2. Create a test directory under your package | ||
3. Add the "launch_text_gp8.xml" file and fill out the test below. Use the | ||
following conventions: | ||
a. Encapsulate each launch file test in it's own namespace. By | ||
convention the namespace should have the same name as the launch | ||
file (minus ".launch" extension) | ||
b. Create tests for each possible combination of parameters. Utilize | ||
sub-namespaces under the main namespace. | ||
Notes: | ||
1. XML extension is used in order to avoid beinging included | ||
in roslaunch auto-complete. | ||
2. Group tags with namespaces are used to avoid node name collisions when | ||
testing multpile launch files | ||
--> | ||
<launch> | ||
<arg name="req_arg" value="default" /> | ||
<arg name="controller" value="yrc1000" /> | ||
|
||
<group ns="load_gp8"> | ||
<include file="$(find motoman_gp8_support)/launch/load_gp8.launch" /> | ||
</group> | ||
|
||
<group ns="test_gp8"> | ||
<include file="$(find motoman_gp8_support)/launch/test_gp8.launch" /> | ||
</group> | ||
|
||
<group ns="robot_interface_streaming_gp8"> | ||
<group ns="$(arg controller)"> | ||
<include file="$(find motoman_gp8_support)/launch/robot_interface_streaming_gp8.launch"> | ||
<arg name="robot_ip" value="$(arg req_arg)" /> | ||
<arg name="controller" value="$(arg controller)" /> | ||
</include> | ||
</group> | ||
</group> | ||
|
||
<group ns="robot_state_visualize_gp8"> | ||
<group ns="$(arg controller)"> | ||
<include file="$(find motoman_gp8_support)/launch/robot_state_visualize_gp8.launch"> | ||
<arg name="robot_ip" value="$(arg req_arg)" /> | ||
<arg name="controller" value="$(arg controller)" /> | ||
</include> | ||
</group> | ||
</group> | ||
|
||
</launch> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a downsampled version of the
visual
mesh?(just noticed the
visual
mesh is 1MB+. Not sure what happened during the review when that was initially contributed ..)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That might have been from a 3D model that included a lot of internal elements which makes if harder reduce but still keep details. I should be able to generate new .dae model by converting MotoSim models that are already reduced.
@gavanderhoorn Do you want me to do it on this PR, or it's probably better to create a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, no need.
It's already in the history of the repository, so adding a newer version will not reduce the total size.