add logic for 'params_file' to handle both string and string_array

[saikishor]

Might be useful to have params_file to be both string and string_array

[fmauch]

This seems valid and I verified locally that this fixes a regression with the controller tests introduced earlier. Thanks @saikishor for the quick fix!

[codecov]

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.85%. Comparing base (73fe227) to head (72483f0).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
controller_manager/src/controller_manager.cpp	69.23%	1 Missing and 3 partials ⚠️
controller_manager/test/test_spawner_unspawner.cpp	93.75%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1898   +/-   ##
=======================================
  Coverage   87.84%   87.85%           
=======================================
  Files         121      121           
  Lines       12497    12515   +18     
  Branches     1124     1124           
=======================================
+ Hits        10978    10995   +17     
- Misses       1107     1108    +1     
  Partials      412      412           

Flag	Coverage Δ
unittests	87.85% <82.75%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp	99.09% <93.75%> (-0.27%)	⬇️
controller_manager/src/controller_manager.cpp	78.29% <69.23%> (+0.03%)	⬆️

[christophfroehlich]

Should we add a test for that functionality, or at least open a follow-up issue in doing so to quickly fix ros2_controllers test regression?

[saikishor]

Should we add a test for that functionality, or at least open a follow-up issue in doing so to quickly fix ros2_controllers test regression?

Sure, I can add test to this one. Right now, I'm in middle of something I can do it right after that.

[christophfroehlich]

Humble test is failing

     unknown file: Failure
    C++ exception with description "parameter 'joint_names' has already been declared" thrown in the test body.
    [  FAILED  ] TestLoadController.spawner_test_with_params_file_string_parameter (741 ms)