-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spawner] Accept parsing multiple --param-file
arguments to spawner (backport #1805)
#1894
Conversation
Cherry-pick of 73fe227 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
f42ef1a
to
825ebfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## humble #1894 +/- ##
==========================================
- Coverage 63.18% 63.00% -0.19%
==========================================
Files 109 109
Lines 12290 12448 +158
Branches 8314 8444 +130
==========================================
+ Hits 7766 7843 +77
- Misses 820 841 +21
- Partials 3704 3764 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
|
When we use multiple controlers to activate or deactivate, it is quite cumbersome to accept only one
--param-file
arg as it is not very scalable. For this reason, now the spawner can accept multiple --param-file args and set the respective param_file to those corresponding controllers.Along with the above mentioned change, now the controllers can accept multiple param-file args as well, and this is very helpful to be able to override parameters between parameter files as how it is done with the standard ROS 2 nodes
This is an automatic backport of pull request #1805 done by Mergify.