controller_manager_srvs tests: Add text to assertions

[fmauch]

This should make debugging failed tests easier.

With this test a flip in a test matrix such as

ros2_control/controller_manager/test/test_hardware_management_srvs.cpp

Lines 230 to 247 in 5065d0c

	list_hardware_components_and_check(
	// actuator, sensor, system
	std::vector<uint8_t>(
	{LFC_STATE::PRIMARY_STATE_ACTIVE, LFC_STATE::PRIMARY_STATE_INACTIVE,
	LFC_STATE::PRIMARY_STATE_UNCONFIGURED}),
	std::vector<std::string>({ACTIVE, INACTIVE, UNCONFIGURED}),
	std::vector<std::vector<std::vector<bool>>>({
	// is available
	{{true, true}, {true, true, true}}, // actuator
	{{}, {true}}, // sensor
	{{false, false, false, false}, {false, false, false, false, false, false, false}}, // system
	}),
	std::vector<std::vector<std::vector<bool>>>({
	// is claimed
	{{false, false}, {false, false, false}}, // actuator
	{{}, {false}}, // sensor
	{{false, false, false, false}, {false, false, false, false, false, false, false}}, // system
	}));

will produce a test output such as

/home/mauch/robot_folders/checkout/ros2_control/colcon_ws/src/ros2_control/controller_manager/test/test_hardware_management_srvs.cpp:133: Failure                                                                                           
Expected equality of these values:                                                                                                                                                                                                          
  interfaces[i].is_available                                                                                                                                                                                                                
    Which is: true                                                                                                                                                                                                                          
  is_available_status[i]                                                                                                                                                                                                                    
    Which is: false                                                                                                                                                                                                                         
At joint1/velocity                                                                                                                                                                                                                          
[  FAILED  ] TestControllerManagerHWManagementSrvs.list_hardware_components (104 ms)

while without this change it would only have been

/home/mauch/robot_folders/checkout/ros2_control/colcon_ws/src/ros2_control/controller_manager/test/test_hardware_management_srvs.cpp:133: Failure                                                                                           
Expected equality of these values:                                                                                                                                                                                                          
  interfaces[i].is_available                                                                                                                                                                                                                
    Which is: true                                                                                                                                                                                                                          
  is_available_status[i]                                                                                                                                                                                                                    
    Which is: false                                                                                                                                                                                                                                                                                                            
[  FAILED  ] TestControllerManagerHWManagementSrvs.list_hardware_components (104 ms)

which makes debugging this a lot harder, since the referenced line is from the reused function instead of the actual calling block.

[codecov-commenter]

Codecov Report

Merging #1023 (c741f00) into master (925f5f3) will decrease coverage by 1.95%.
The diff coverage is 35.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1023      +/-   ##
==========================================
- Coverage   34.61%   32.67%   -1.95%     
==========================================
  Files          52       91      +39     
  Lines        2981     9560    +6579     
  Branches     1855     6440    +4585     
==========================================
+ Hits         1032     3124    +2092     
- Misses        310      711     +401     
- Partials     1639     5725    +4086     

Flag	Coverage Δ
unittests	32.67% <35.54%> (-1.95%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
controller_manager/src/controller_manager.cpp	38.27% <ø> (-1.44%)	⬇️
controller_manager/src/ros2_control_node.cpp	0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp	100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp	100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp	100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp	49.91% <ø> (-3.72%)	⬇️
hardware_interface/src/sensor.cpp	50.52% <ø> (ø)
hardware_interface/src/system.cpp	55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp	9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp	32.44% <ø> (+4.25%)	⬆️
... and 68 more

... and 19 files with indirect coverage changes

[bmagyar]

Ah these are very nice, thank you!

[bmagyar]

@Mergifyio backport humble

[mergify]

backport humble

✅ Backports have been created

• #1029 controller_manager_srvs tests: Add text to assertions (backport #1023) has been created for branch humble but encountered conflicts