Remove log-level argument from spawner script #1013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to partially revert the changes in PR 972 which added a log-level argument to the spawner to control the output of the spawner node using the logging level. It turns out that using standard ros-args conventions for the 'ros2 run' command to set the logging level was sufficient.
So instead of adding a new way to set the logging level of the spawner with:
ros2 run controller_manager spawner --log-level WARN
the old way using ros-args was sufficient:
ros2 run controller_manager spawner --ros-args --log-level WARN
I have tested that this works.