Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] FoldRegMems: insert new ops into same block as memory #7909

Merged
merged 1 commit into from
Nov 27, 2024

Commits on Nov 27, 2024

  1. [FIRRTL] FoldRegMems: insert new ops into same block as memory

    Before this PR, FoldRegMems would construct new ops in the "body of the parent
    FModuleOp". We need to place these ops in the same block as the memory.
    
    This PR fixes a bug where, when a memory under a layerblock was canonicalized
    to a register, the register would be placed at the original location of the
    memory (under the layerblock), but its readers would be placed outside the
    layerblock, resulting in a dominance checking error.
    rwy7 committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    b3c81d0 View commit details
    Browse the repository at this point in the history