- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2.6k
Generalize command resampling #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Description This MR fixes the color of the ground in Orbit. It is now black since we like that color more. It also fixes the setting of the translation of the ground plane. Earlier, it was taking z height from the configuration. Instead, now it expects to get the full translation as an argument to its function. This is needed to make it consistent with interactive scene designing API. ## Type of change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Screenshot  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
| Did a very high-level parse of the code. Overall, this is an interesting feature. However, it seems that resampling time term inherited from a manager term class is an overkill. Wouldn't it be easier to have it as a function instead? From what I see, the following function signature should suffice. def my_samping_func(env_ids: Sequence[int], *args) -> torch.Tensor | 
| A simple function would suffice for some applications but even the current fixed time resampling mechanism needs persistent storage you cannot have inside a function. It needs to keep track of the time left. So I definitely think a resampling class is necessary. But if you think it would be better to create a dedicated resampling class for this behavior, I could be convinced that the manager is not necessary :) | 
3e7a470    to
    cfcabba      
    Compare
  
    | @Mayankm96 Any movement on this? Happy to resolve all conflicts, if you are still interested in this. | 
# Description This MR fixes the color of the ground in Orbit. It is now black since we like that color more. It also fixes the setting of the translation of the ground plane. Earlier, it was taking z height from the configuration. Instead, now it expects to get the full translation as an argument to its function. This is needed to make it consistent with interactive scene designing API. ## Type of change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Screenshot  ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./orbit.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file
Adds support to record additional steps after task success is detected in record_demos.py. This helps record demos with sufficient lengths to be used for training. <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Adds support to record additional steps after task success is detected in record_demos.py. This helps record demos with sufficient lengths to be used for training. <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
…#224) Adds support to record additional steps after task success is detected in record_demos.py. This helps record demos with sufficient lengths to be used for training. <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
Description
This introduces the concept of a
ResamplingManagerandResamplingTerms. This generalizes command resampling beyond the currently implemented fixed time resampling.Every
CommandTermnow owns aResamplingManagerwhich it calls during thecompute()call to determine whether commands should be resampled.A
ResamplingMangercan contain multipleRewardTerms to obtain diverse behavior.All current example RL environment configs which used a command other than the
NullCommandwhere changed to use the newFixedFrequencyresampling term, which replicates the current behavior. TheNullCommandnow simply receives nowResamplingTermand is therefore never resampled, as desired.However, this is a breaking change for people who created their own RL configs outside of the Orbit main branch. Luckily, this is very easy to fix with a single line code change:
resampling_time_range=(10.0, 10.0)-->resampling={"fixed_frequency": FixedFrequencyCfg(resampling_time_range=(10.0, 10.0))},I also added a new
RandomChanceresampling term as an example, which resamples environments with a fixed probability.Fixes #223
Type of change
Checklist
pre-commitchecks with./orbit.sh --format./orbit.sh --testand they passconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there