Perform FXAA in SRGB space as described by algorithm #99339
Closed
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaturnsan
changed the title
mrsaturnsan
force-pushed
the
fxaa_fix
branch
from
5d3dabf
to
d3e59ff
Compare
|
Can you show what difference does it make? |
No Anti Aliasing
Before change
After change
Difference
|
|
Just a heads up that we intend to replace our FXAA implementation before 4.4 #89582 |
|
Thanks for the heads up! In that case this PR is unnecessary so will close out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FXAA runs in SRGB space so convert linear colors to SRGB before computing color.
https://developer.download.nvidia.com/assets/gamedev/files/sdk/11/FXAA_WhitePaper.pdf